All of lore.kernel.org
 help / color / mirror / Atom feed
From: Mark Lord <liml@rtr.ca>
To: IDE/ATA development list <linux-ide@vger.kernel.org>,
	Jeff Garzik <jgarzik@pobox.com>
Cc: Artem Bokhan <aptem@ngs.ru>, Harri Olin <harri.olin@gmail.com>,
	Brian Rademacher <rad@radfiles.net>,
	Eamonn Hamilton <EAMONN.HAMILTON@saic.com>,
	stable@kernel.org
Subject: [PATCH] sata_mv: fix timeouts on lower ports of 508x/6081 chips
Date: Fri, 16 Jan 2009 12:03:02 -0500	[thread overview]
Message-ID: <4970BDC6.7020201@rtr.ca> (raw)
In-Reply-To: <496F34BF.5010701@ngs.ru>

Fix a longstanding bug for the 8-port Marvell Sata controllers (508x/6081),
where accesses to the upper 4 ports would cause lost-interrupts / timeouts
for the lower 4-ports.  With this patch, the 6081 boards should finally be
reliable enough for mainstream use with Linux.

This patch is for 2.6.29, but should also get reviewed/released
for the -stable branches of 2.6.28, 2.6.27, and 2.6.26.

Signed-off-by: Mark Lord <mlord@pobox.com>

--- linux-2.6.29-rc1-git6/drivers/ata/sata_mv.c	2009-01-16 11:11:16.000000000 -0500
+++ linux/drivers/ata/sata_mv.c	2009-01-16 11:52:17.000000000 -0500
@@ -883,7 +883,7 @@
 		struct mv_host_priv *hpriv = ap->host->private_data;
 		int hardport = mv_hardport_from_port(ap->port_no);
 		void __iomem *hc_mmio = mv_hc_base_from_port(
-					mv_host_base(ap->host), hardport);
+					mv_host_base(ap->host), ap->port_no);
 		u32 hc_irq_cause, ipending;
 
 		/* clear EDMA event indicators, if any */

  reply	other threads:[~2009-01-16 17:03 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-01-13 21:17 sata_mv: trial fix for lost NCQ interrupts Mark Lord
2009-01-14 21:06 ` Harri Olin
2009-01-14 21:26   ` Jeff Garzik
2009-01-14 22:08     ` Mark Lord
2009-01-14 22:06   ` Mark Lord
2009-01-14 23:18     ` Harri Olin
2009-01-14 23:22       ` Brian Rademacher
2009-01-15  2:53       ` Mark Lord
2009-01-15 13:06         ` Artem Bokhan
2009-01-16 17:03           ` Mark Lord [this message]
2009-01-16 20:08             ` [PATCH] sata_mv: fix timeouts on lower ports of 508x/6081 chips Harri Olin
2009-01-17  2:10               ` Brian Rademacher
2009-01-14 22:01 ` sata_mv: trial fix for lost NCQ interrupts Brian Rademacher

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4970BDC6.7020201@rtr.ca \
    --to=liml@rtr.ca \
    --cc=EAMONN.HAMILTON@saic.com \
    --cc=aptem@ngs.ru \
    --cc=harri.olin@gmail.com \
    --cc=jgarzik@pobox.com \
    --cc=linux-ide@vger.kernel.org \
    --cc=rad@radfiles.net \
    --cc=stable@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.