Re: [PATCH 1/2] libiscsi: fix iscsi pool leak

[Mike Christie <michaelc@cs.wisc.edu>]

I forgot to send a 0/2 patch.

These two patches were made over scsi-rc-fixes.


michaelc@cs.wisc.edu wrote:
> From: Mike Christie <michaelc@cs.wisc.edu>
> 
> I am not sure what happened. It looks like we have always leaked
> the q->queue that is allocated from the kfifo_init call. nab finally
> noticed that we were leaking and this patch fixes it by adding a
> kfree call to iscsi_pool_free. kfifo_free is not used per kfifo_init's
> instructions to use kfree.
> 
> Signed-off-by: Mike Christie <michaelc@cs.wisc.edu>
> ---
>  drivers/scsi/libiscsi.c |    1 +
>  1 files changed, 1 insertions(+), 0 deletions(-)
> 
> diff --git a/drivers/scsi/libiscsi.c b/drivers/scsi/libiscsi.c
> index 7225b6e..257c241 100644
> --- a/drivers/scsi/libiscsi.c
> +++ b/drivers/scsi/libiscsi.c
> @@ -1981,6 +1981,7 @@ void iscsi_pool_free(struct iscsi_pool *q)
>  		kfree(q->pool[i]);
>  	if (q->pool)
>  		kfree(q->pool);
> +	kfree(q->queue);
>  }
>  EXPORT_SYMBOL_GPL(iscsi_pool_free);
>