All of lore.kernel.org
 help / color / mirror / Atom feed
From: Alexey Starikovskiy <astarikovskiy@suse.de>
To: Tero Roponen <tero.roponen@gmail.com>
Cc: linux-acpi@vger.kernel.org, len.brown@intel.com
Subject: Re: [PATCH] ACPI: Fix crash on ASUS laptops
Date: Sat, 17 Jan 2009 20:20:02 +0300	[thread overview]
Message-ID: <49721342.40305@suse.de> (raw)
In-Reply-To: <alpine.LFD.2.00.0901171303040.3032@localhost.localdomain>

Thanks, ACK
Alex.
Tero Roponen wrote:
> This patch fixes the crash I experienced in 2.6.29-rc2.
> Tested on ASUS M50vm.
> 
> Signed-off-by: Tero Roponen <tero.roponen@gmail.com>
> 
> diff --git a/drivers/acpi/ec.c b/drivers/acpi/ec.c
> index a2b82c9..5c2f5d3 100644
> --- a/drivers/acpi/ec.c
> +++ b/drivers/acpi/ec.c
> @@ -982,7 +982,7 @@ int __init acpi_ec_ecdt_probe(void)
>  		saved_ec = kmalloc(sizeof(struct acpi_ec), GFP_KERNEL);
>  		if (!saved_ec)
>  			return -ENOMEM;
> -		memcpy(&saved_ec, boot_ec, sizeof(saved_ec));
> +		memcpy(saved_ec, boot_ec, sizeof(*saved_ec));
>  	/* fall through */
>  	}
>  	/* This workaround is needed only on some broken machines,


  reply	other threads:[~2009-01-17 17:20 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-01-17 11:06 [PATCH] ACPI: Fix crash on ASUS laptops Tero Roponen
2009-01-17 17:20 ` Alexey Starikovskiy [this message]
2009-01-18  1:17   ` Len Brown

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=49721342.40305@suse.de \
    --to=astarikovskiy@suse.de \
    --cc=len.brown@intel.com \
    --cc=linux-acpi@vger.kernel.org \
    --cc=tero.roponen@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.