All of lore.kernel.org
 help / color / mirror / Atom feed
From: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
To: Maxime Ripard <maxime.ripard@free-electrons.com>
Cc: Mauro Carvalho Chehab <mchehab@kernel.org>, linux-media@vger.kernel.org
Subject: Re: [PATCH] [media] Order the Makefile alphabetically
Date: Thu, 06 Apr 2017 17:44:54 +0300	[thread overview]
Message-ID: <49731556.CDPzbN8maI@avalon> (raw)
In-Reply-To: <20170406144051.13008-1-maxime.ripard@free-electrons.com>

Hi Maxime,

Thank you for the patch.

On Thursday 06 Apr 2017 16:40:51 Maxime Ripard wrote:
> The Makefiles were a free for all without a clear order defined. Sort all
> the options based on the Kconfig symbol.
> 
> Signed-off-by: Maxime Ripard <maxime.ripard@free-electrons.com>

I like the approach.

Acked-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>

(I haven't reviewed the changes in detail though, I trust that you have 
double-checked through automated means that no Kconfig symbol was lost.)

> ---
> 
> Hi Mauro,
> 
> Here is my makefile ordering patch again, this time with all the Makefiles
> in drivers/media that needed ordering.
> 
> Since we're already pretty late in the release period, I guess there won't
> be any major conflicts between now and the merge window.
> 
> Maxime
> ---
>  drivers/media/common/Makefile        |   2 +-
>  drivers/media/dvb-frontends/Makefile | 220 +++++++++++++++----------------
>  drivers/media/i2c/Makefile           | 162 +++++++++++++-------------
>  drivers/media/pci/Makefile           |  34 +++---
>  drivers/media/platform/Makefile      |  92 +++++----------
>  drivers/media/radio/Makefile         |  62 +++++-----
>  drivers/media/rc/Makefile            |  74 ++++++------
>  drivers/media/tuners/Makefile        |  73 ++++++------
>  drivers/media/usb/Makefile           |  34 +++---
>  drivers/media/v4l2-core/Makefile     |  36 +++---
>  10 files changed, 381 insertions(+), 408 deletions(-)

-- 
Regards,

Laurent Pinchart

  reply	other threads:[~2017-04-06 14:44 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-04-06 14:40 [PATCH] [media] Order the Makefile alphabetically Maxime Ripard
2017-04-06 14:44 ` Laurent Pinchart [this message]
2017-04-19 11:15 ` Mauro Carvalho Chehab
2017-04-21 14:41   ` Maxime Ripard
2017-04-21 15:11     ` Mauro Carvalho Chehab
2017-04-24 14:47       ` Sakari Ailus

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=49731556.CDPzbN8maI@avalon \
    --to=laurent.pinchart@ideasonboard.com \
    --cc=linux-media@vger.kernel.org \
    --cc=maxime.ripard@free-electrons.com \
    --cc=mchehab@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.