From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1LOXAU-0005RC-QY
	for qemu-devel@nongnu.org; Sun, 18 Jan 2009 07:54:22 -0500
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1LOXAS-0005R0-TI
	for qemu-devel@nongnu.org; Sun, 18 Jan 2009 07:54:22 -0500
Received: from [199.232.76.173] (port=56807 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1LOXAS-0005Qx-Op
	for qemu-devel@nongnu.org; Sun, 18 Jan 2009 07:54:20 -0500
Received: from vsmtp04.dti.ne.jp ([202.216.231.139]:46050)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <kawasaki@juno.dti.ne.jp>) id 1LOXAR-000478-Vw
	for qemu-devel@nongnu.org; Sun, 18 Jan 2009 07:54:20 -0500
Received: from [192.168.1.21] (PPPa1787.e11.eacc.dti.ne.jp [124.255.93.17]) by
	vsmtp04.dti.ne.jp (3.11v) with ESMTP AUTH id n0ICsF4t004974 for
	<qemu-devel@nongnu.org>; Sun, 18 Jan 2009 21:54:15 +0900 (JST)
Message-ID: <4973267B.9010901@juno.dti.ne.jp>
Date: Sun, 18 Jan 2009 21:54:19 +0900
From: Shin-ichiro KAWASAKI <kawasaki@juno.dti.ne.jp>
MIME-Version: 1.0
Subject: Re: [Qemu-devel] [6344] graphical_console_init change
	(Stefano	Stabellini)
References: <E1LNtzL-0002pj-7r@cvs.savannah.gnu.org>
In-Reply-To: <E1LNtzL-0002pj-7r@cvs.savannah.gnu.org>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Reply-To: qemu-devel@nongnu.org
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: qemu-devel@nongnu.org

Hi.

Anthony Liguori wrote:
> Revision: 6344
>           http://svn.sv.gnu.org/viewvc/?view=rev&root=qemu&revision=6344
> Author:   aliguori
> Date:     2009-01-16 19:04:14 +0000 (Fri, 16 Jan 2009)
> 
> Log Message:
> -----------
> graphical_console_init change (Stefano Stabellini)
> 
(snip)

> Modified: trunk/vl.c
> ===================================================================
> --- trunk/vl.c	2009-01-16 18:13:32 UTC (rev 6343)
> +++ trunk/vl.c	2009-01-16 19:04:14 UTC (rev 6344)
(snip)
> +    /* just use the first displaystate for the moment */
> +    ds = display_state;
>      /* terminal init */
> -    memset(&display_state, 0, sizeof(display_state));
> -    ds->surface = qemu_create_displaysurface(640, 480, 32, 640 * 4);
>      if (nographic) {
>          if (curses) {
>              fprintf(stderr, "fatal: -nographic can't be used with -curses\n");

This commit seems to cause segmentation fault for boards which has no graphics
display.  I saw the fault when I working with my SE7750 board support patch, and
invoking with -nographic options. The fault happens in dump_display_init(ds) 
within the 'if (nographic)' block quoted above.  The argument ds is NULL because
no graphic board initialize it, I guess.  Some null check for ds or dummy ds might
be needed, for such cases.


Regards,
Shin-ichiro KAWASAKI