From: Michael Tokarev <mjt@tls.msk.ru>
To: matvejchikov@gmail.com
Cc: netdev@vger.kernel.org
Subject: Re: [PATCH] net: A little dev_valid_name() improvement
Date: Sun, 18 Jan 2009 23:28:46 +0300 [thread overview]
Message-ID: <497390FE.4050909@msgid.tls.msk.ru> (raw)
In-Reply-To: <8496f91a0901181107o17ee80e7h7fab67194a7bde23@mail.gmail.com>
Matvejchikov Ilya wrote:
> This patch removes redundant complexity when checking the
> network device name to be valid.
And also disallows any name starting with a dot, while
previously it was allowed/valid.
I don't think this patch is good.
/mjt
> - if (*name == '\0')
> + if (*name == '\0' || *name == '.')
> return 0;
> - if (!strcmp(name, ".") || !strcmp(name, ".."))
> - return 0;
next prev parent reply other threads:[~2009-01-18 20:28 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-01-18 19:07 [PATCH] net: A little dev_valid_name() improvement Matvejchikov Ilya
2009-01-18 20:28 ` Michael Tokarev [this message]
2009-01-19 2:17 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=497390FE.4050909@msgid.tls.msk.ru \
--to=mjt@tls.msk.ru \
--cc=matvejchikov@gmail.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.