From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with archive (Exim 4.43)
	id 1LP15d-0001OS-Ow
	for mharc-grub-devel@gnu.org; Mon, 19 Jan 2009 15:51:21 -0500
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1LP15b-0001NC-L9
	for grub-devel@gnu.org; Mon, 19 Jan 2009 15:51:19 -0500
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1LP15a-0001MX-2A
	for grub-devel@gnu.org; Mon, 19 Jan 2009 15:51:19 -0500
Received: from [199.232.76.173] (port=50415 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1LP15Z-0001MQ-Tn
	for grub-devel@gnu.org; Mon, 19 Jan 2009 15:51:17 -0500
Received: from mailout08.t-online.de ([194.25.134.20]:37998)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <Christian.Franke@t-online.de>) id 1LP15Z-0007g4-Fd
	for grub-devel@gnu.org; Mon, 19 Jan 2009 15:51:17 -0500
Received: from fwd08.aul.t-online.de by mailout08.sul.t-online.de with smtp 
	id 1LP15Y-0005nx-00; Mon, 19 Jan 2009 21:51:16 +0100
Received: from [10.3.2.2]
	(V86Vx4ZcghhitO6qKtow3rs98pt-H07DYjcr21EaIQa3+QT83F0-lJhLsgreTNEQZ4@[217.235.235.32])
	by fwd08.aul.t-online.de
	with esmtp id 1LP15C-2E04ki0; Mon, 19 Jan 2009 21:50:54 +0100
Message-ID: <4974E7AF.9030001@t-online.de>
Date: Mon, 19 Jan 2009 21:50:55 +0100
From: Christian Franke <Christian.Franke@t-online.de>
User-Agent: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US;
	rv:1.8.1.16) Gecko/20080702 SeaMonkey/1.1.11
MIME-Version: 1.0
To: The development of GRUB 2 <grub-devel@gnu.org>
References: <497376DE.1030302@t-online.de> <874ozvsisy.fsf@xs4all.nl>
	<1LOtU4-0rd5O40@fwd04.aul.t-online.de>
In-Reply-To: <1LOtU4-0rd5O40@fwd04.aul.t-online.de>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
X-ID: V86Vx4ZcghhitO6qKtow3rs98pt-H07DYjcr21EaIQa3+QT83F0-lJhLsgreTNEQZ4
X-TOI-MSGID: 100b3004-c487-41d1-be2f-f0eb119f9706
X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6 (newer, 3)
Subject: Re: [PATCH] (ata.mod) Fix ATAPI protocol
X-BeenThere: grub-devel@gnu.org
X-Mailman-Version: 2.1.5
Precedence: list
Reply-To: The development of GRUB 2 <grub-devel@gnu.org>
List-Id: The development of GRUB 2 <grub-devel.gnu.org>
List-Unsubscribe: <http://lists.gnu.org/mailman/listinfo/grub-devel>,
	<mailto:grub-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/grub-devel>
List-Post: <mailto:grub-devel@gnu.org>
List-Help: <mailto:grub-devel-request@gnu.org?subject=help>
List-Subscribe: <http://lists.gnu.org/mailman/listinfo/grub-devel>,
	<mailto:grub-devel-request@gnu.org?subject=subscribe>
X-List-Received-Date: Mon, 19 Jan 2009 20:51:19 -0000

Christian Franke wrote:
> Marco Gerards wrote:
>   
>> Christian Franke <...> writes:
>>
>>     
>>> This patch fixes the data I/O protocol of the ATA PACKET command.
>>>
>>> The current implementation does not read the byte count
>>> registers. ATAPI read may not work if the drive sends the data in
>>> more than one block.
>>>
>>> In conjunction with my recent SCSI blocksize patch, ATAPI CD/DVD
>>> drives should now work.
>>>
>>>       
>> Sorry for not commenting on many things on this list.  I am too busy
>> to check all this.  
>>     
>
> N.P.
>
> Meantime, I have tested the SCSI and ATAPI fixes on several PC. If there
> are no further comments, I will commit these soon.
>
>   

Committed, plus an additional wait in grub_atapi_identify.

Open issues:
- grub_pio_read/write() check the ERR bit without ensuring !BSY.
- ata_read fails if (batch % size) == 0.
- ata_write does not work at all, it uses the read cmd.

Christian