From: Sergei Shtylyov <sshtylyov@ru.mvista.com>
To: Alan Cox <alan@lxorguk.ukuu.org.uk>
Cc: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>,
linux-ide@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/6] ide: move SFF I/O code to ide-io-sff.c
Date: Tue, 20 Jan 2009 00:48:05 +0300 [thread overview]
Message-ID: <4974F515.4030304@ru.mvista.com> (raw)
In-Reply-To: <20090119213101.798fe1cd@lxorguk.ukuu.org.uk>
Hello.
Alan Cox wrote:
>>> I'm afraid you are the one who is wrong. The IDE layer is duplicating a
>>> generic level of indirection with its own code - purely because IDE
>>> pre-dates that core functionality. The whole IDE layer indirection can go
>>> away because Linux has caught up with the needs of the IDE layer.
>>>
>> What IDE indirection you're talking about anyway?
>>
>
> As I said earlier ide_mm_inb etc via the function pointers tf_inb/tf_outb
> etc.
>
Ah... at least they don't have additional address checks that
ioread*()/iowrite*() have...
> Given how small those functions are it might even be worth rolling them
> into two different versions of the functions like ide_tf_read as surely
> it costs more to call them (in size) than to inline the two for those
> functions?
>
Indeed.
WBR, Sergei
next prev parent reply other threads:[~2009-01-19 21:48 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-01-19 13:03 [PATCH 0/6] ide: more core code housekeeping Bartlomiej Zolnierkiewicz
2009-01-19 13:03 ` [PATCH 1/6] ide: move ide_read_bcount_and_ireason() to ide-atapi.c Bartlomiej Zolnierkiewicz
2009-01-19 13:03 ` [PATCH 2/6] ide: move SFF I/O code to ide-io-sff.c Bartlomiej Zolnierkiewicz
2009-01-19 14:17 ` Sergei Shtylyov
2009-01-19 14:23 ` Bartlomiej Zolnierkiewicz
2009-01-19 14:29 ` Sergei Shtylyov
2009-01-19 14:31 ` Sergei Shtylyov
2009-01-19 14:35 ` Bartlomiej Zolnierkiewicz
2009-01-19 17:37 ` Alan Cox
2009-01-19 18:02 ` Sergei Shtylyov
2009-01-19 18:36 ` Alan Cox
2009-01-19 18:46 ` Sergei Shtylyov
2009-01-19 18:49 ` Alan Cox
2009-01-19 19:04 ` Sergei Shtylyov
2009-01-19 21:31 ` Alan Cox
2009-01-19 21:48 ` Sergei Shtylyov [this message]
2009-01-19 22:37 ` Sergei Shtylyov
2009-01-19 19:12 ` Bartlomiej Zolnierkiewicz
2009-01-19 19:53 ` Sergei Shtylyov
2009-01-19 16:39 ` Sergei Shtylyov
2009-01-19 13:03 ` [PATCH 3/6] ide: fix printk() levels in [atapi_]reset_pollfunc() Bartlomiej Zolnierkiewicz
2009-01-19 14:28 ` Sergei Shtylyov
2009-01-19 13:03 ` [PATCH 4/6] ide: fix comments in ide_config_drive_speed() Bartlomiej Zolnierkiewicz
2009-01-19 14:25 ` Sergei Shtylyov
2009-01-19 13:03 ` [PATCH 5/6] ide: checkpatch.pl fixes for ide-iops.c Bartlomiej Zolnierkiewicz
2009-01-19 13:03 ` [PATCH 6/6] ide: move error handling code to ide-eh.c Bartlomiej Zolnierkiewicz
2009-01-19 14:19 ` [PATCH 0/6] ide: more core code housekeeping Sergei Shtylyov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4974F515.4030304@ru.mvista.com \
--to=sshtylyov@ru.mvista.com \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=bzolnier@gmail.com \
--cc=linux-ide@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.