From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from sfi-mx-2.v28.ch3.sourceforge.com ([172.29.28.122] helo=mx.sourceforge.net) by 3yr0jf1.ch3.sourceforge.com with esmtp (Exim 4.69) (envelope-from ) id 1LP7gL-00038t-Pf for user-mode-linux-devel@lists.sourceforge.net; Tue, 20 Jan 2009 03:53:41 +0000 Received: from out02.mta.xmission.com ([166.70.13.232]) by 72vjzd1.ch3.sourceforge.com with esmtp (Exim 4.69) id 1LP7gJ-0001Rq-Gw for user-mode-linux-devel@lists.sourceforge.net; Tue, 20 Jan 2009 03:53:41 +0000 Message-ID: <49753063.8040007@hathawaymix.org> Date: Mon, 19 Jan 2009 19:01:07 -0700 From: Shane Hathaway MIME-Version: 1.0 References: <20090115194033.GA10926@hack.private> <20090116124158.4364e269.akpm@linux-foundation.org> <200901170328.15178.rob@landley.net> <20090119152104.GC6432@c2.user-mode-linux.org> In-Reply-To: Subject: Re: [uml-devel] [Patch] uml: fix a link error List-Id: The user-mode Linux development list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: user-mode-linux-devel-bounces@lists.sourceforge.net To: Daolong Wang Cc: user-mode-linux-devel@lists.sourceforge.net, Jeff Dike , linux-kernel@vger.kernel.org, Rob Landley , Am?rico Wang , Andrew Morton Daolong Wang wrote: > On Mon, Jan 19, 2009 at 11:21 PM, Jeff Dike wrote: >> On Sun, Jan 18, 2009 at 02:23:46PM +0800, Daolong Wang wrote: >>> I can confirm this link error. >> In what environment? I see no problems here. I can also confirm this link error. The problem occurs when compiling either 2.6.28.1 or 2.6.27.12; I didn't try anything earlier. The patch suggested at this beginning of this thread did solve the link problem and the resulting kernel ran for several hours. However, I think the patch is still probably incorrect. I'm going to repost what I said in another message I sent today, this time with a wider audience: The problem is that the name "sigprocmask" is getting renamed to "kernel_sigprocmask" by a compiler directive in arch/um/Makefile, then that name gets mangled into "sys_kernel_sigprocmask" by the SYSCALL_DEFINE3(sigprocmask, ...) macro in kernel/signal.c. So, instead of the patch suggested earlier, I added the following line to arch/um/sys-i386/sys_call_table.S: #define sys_sigprocmask sys_kernel_sigprocmask This made it compile and link correctly. Look at the symbols generated by the compile of signal.c to see what I mean: # nm kernel/signal.o | grep sigprocmask 0000008f r __kstrtab_kernel_sigprocmask 00000040 r __ksymtab_kernel_sigprocmask 00001ea6 T kernel_sigprocmask 00002d67 T sys_kernel_sigprocmask 00001faf T sys_rt_sigprocmask Unfortunately, it's a mystery to me that others haven't run into this before. My host environment is RHEL 4 inside some kind of chroot. Shane ------------------------------------------------------------------------------ This SF.net email is sponsored by: SourcForge Community SourceForge wants to tell your story. http://p.sf.net/sfu/sf-spreadtheword _______________________________________________ User-mode-linux-devel mailing list User-mode-linux-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/user-mode-linux-devel From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1761686AbZATCB0 (ORCPT ); Mon, 19 Jan 2009 21:01:26 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1757612AbZATCBQ (ORCPT ); Mon, 19 Jan 2009 21:01:16 -0500 Received: from out02.mta.xmission.com ([166.70.13.232]:41765 "EHLO out02.mta.xmission.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756348AbZATCBP (ORCPT ); Mon, 19 Jan 2009 21:01:15 -0500 Message-ID: <49753063.8040007@hathawaymix.org> Date: Mon, 19 Jan 2009 19:01:07 -0700 From: Shane Hathaway User-Agent: Thunderbird 2.0.0.19 (X11/20090106) MIME-Version: 1.0 To: Daolong Wang CC: Jeff Dike , Rob Landley , user-mode-linux-devel@lists.sourceforge.net, Andrew Morton , Am?rico Wang , linux-kernel@vger.kernel.org References: <20090115194033.GA10926@hack.private> <20090116124158.4364e269.akpm@linux-foundation.org> <200901170328.15178.rob@landley.net> <20090119152104.GC6432@c2.user-mode-linux.org> In-Reply-To: X-Enigmail-Version: 0.95.7 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit X-XM-SPF: eid=;;;mid=;;;hst=mx03.mta.xmission.com;;;ip=166.70.244.130;;;frm=shane@hathawaymix.org;;;spf=none X-XM-DomainKey: sender_domain=hathawaymix.org;;;sender=shane@hathawaymix.org;;;status=no signature X-SA-Exim-Connect-IP: 166.70.244.130 X-SA-Exim-Mail-From: shane@hathawaymix.org X-Spam-DCC: XMission; sa02 1397; Body=1 Fuz1=1 Fuz2=1 X-Spam-Combo: ;Daolong Wang X-Spam-Relay-Country: X-Spam-Report: * -1.8 ALL_TRUSTED Passed through trusted hosts only via SMTP * 0.0 T_TM2_M_HEADER_IN_MSG BODY: T_TM2_M_HEADER_IN_MSG * -2.6 BAYES_00 BODY: Bayesian spam probability is 0 to 1% * [score: 0.0023] * -0.0 DCC_CHECK_NEGATIVE Not listed in DCC * [sa02 1397; Body=1 Fuz1=1 Fuz2=1] * 0.0 XM_SPF_Neutral SPF-Neutral Subject: Re: [uml-devel] [Patch] uml: fix a link error X-SA-Exim-Version: 4.2.1 (built Thu, 07 Dec 2006 04:40:56 +0000) X-SA-Exim-Scanned: Yes (on mx03.mta.xmission.com) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Daolong Wang wrote: > On Mon, Jan 19, 2009 at 11:21 PM, Jeff Dike wrote: >> On Sun, Jan 18, 2009 at 02:23:46PM +0800, Daolong Wang wrote: >>> I can confirm this link error. >> In what environment? I see no problems here. I can also confirm this link error. The problem occurs when compiling either 2.6.28.1 or 2.6.27.12; I didn't try anything earlier. The patch suggested at this beginning of this thread did solve the link problem and the resulting kernel ran for several hours. However, I think the patch is still probably incorrect. I'm going to repost what I said in another message I sent today, this time with a wider audience: The problem is that the name "sigprocmask" is getting renamed to "kernel_sigprocmask" by a compiler directive in arch/um/Makefile, then that name gets mangled into "sys_kernel_sigprocmask" by the SYSCALL_DEFINE3(sigprocmask, ...) macro in kernel/signal.c. So, instead of the patch suggested earlier, I added the following line to arch/um/sys-i386/sys_call_table.S: #define sys_sigprocmask sys_kernel_sigprocmask This made it compile and link correctly. Look at the symbols generated by the compile of signal.c to see what I mean: # nm kernel/signal.o | grep sigprocmask 0000008f r __kstrtab_kernel_sigprocmask 00000040 r __ksymtab_kernel_sigprocmask 00001ea6 T kernel_sigprocmask 00002d67 T sys_kernel_sigprocmask 00001faf T sys_rt_sigprocmask Unfortunately, it's a mystery to me that others haven't run into this before. My host environment is RHEL 4 inside some kind of chroot. Shane