From: "Duje Mihanović" <duje.mihanovic@skole.hr>
To: Tom Rini <trini@konsulko.com>, Stefan Roese <sr@denx.de>
Cc: Karel Balej <balejk@matfyz.cz>,
~postmarketos/upstreaming@lists.sr.ht, u-boot@lists.denx.de
Subject: Re: [PATCH v2 1/3] serial: ns16550: Add Intel XScale support
Date: Tue, 07 Jan 2025 19:06:21 +0100 [thread overview]
Message-ID: <4975523.31r3eYUQgx@radijator> (raw)
In-Reply-To: <0f39cd7a-c64c-45b6-9e69-4612b884c15f@denx.de>
On Tuesday 7 January 2025 12:30:40 Central European Standard Time Stefan Roese
wrote:
> On 31.12.24 17:49, Duje Mihanović wrote:
> > { .compatible = "ingenic,jz4780-uart", .data = PORT_JZ4780 },
> > { .compatible = "nvidia,tegra20-uart", .data = PORT_NS16550 },
> > { .compatible = "snps,dw-apb-uart", .data = PORT_NS16550 },
> >
> > + { .compatible = "intel,xscale-uart", .data = PORT_NS16550 },
>
> Looking at the Linux 8250 of_device_id struct I see this entry:
>
> { .compatible = "mrvl,mmp-uart",
> .data = (void *)PORT_XSCALE, },
>
> Wouldn't it make more sense to use this compatible property instead?
I was going by the logic that intel,xscale-uart is more generic. They use
identical platform data, so it would be no problem at all.
Regards,
--
Duje
next prev parent reply other threads:[~2025-01-07 18:09 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-12-31 16:49 [PATCH v2 0/3] Initial support for PXA1908 and samsung-coreprimevelte Duje Mihanović
2024-12-31 16:49 ` [PATCH v2 1/3] serial: ns16550: Add Intel XScale support Duje Mihanović
2025-01-07 11:30 ` Stefan Roese
2025-01-07 18:06 ` Duje Mihanović [this message]
2025-01-08 13:43 ` Stefan Roese
2025-01-08 21:26 ` Duje Mihanović
2025-01-09 7:47 ` Stefan Roese
2024-12-31 16:49 ` [PATCH v2 2/3] arm: mmp: add initial support for PXA1908 SoC Duje Mihanović
2025-01-23 12:25 ` Stefan Roese
2025-01-24 15:17 ` Duje Mihanović
2024-12-31 16:49 ` [PATCH v2 3/3] board: samsung: add initial support for coreprimevelte board Duje Mihanović
2025-01-01 12:45 ` [PATCH v2 0/3] Initial support for PXA1908 and samsung-coreprimevelte Duje Mihanović
2025-01-07 11:27 ` Stefan Roese
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4975523.31r3eYUQgx@radijator \
--to=duje.mihanovic@skole.hr \
--cc=balejk@matfyz.cz \
--cc=sr@denx.de \
--cc=trini@konsulko.com \
--cc=u-boot@lists.denx.de \
--cc=~postmarketos/upstreaming@lists.sr.ht \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.