From mboxrd@z Thu Jan 1 00:00:00 1970 From: Hans de Goede Date: Tue, 20 Jan 2009 08:18:48 +0000 Subject: Re: [lm-sensors] [PATCH] hwmon: (f71882fg) Hide misleading error Message-Id: <497588E8.20006@redhat.com> List-Id: References: <20090119211323.02f4df9c@hyperion.delvare> In-Reply-To: <20090119211323.02f4df9c@hyperion.delvare> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: lm-sensors@vger.kernel.org Jean Delvare wrote: > From: Jean Delvare > Subject: hwmon: (f71882fg) Hide misleading error message > > If the F71882FG chip is at address 0x4e, then the probe at 0x2e will > fail with the following message in the logs: > f71882fg: Not a Fintek device > > This is misleading because there is a Fintek device, just at a > different address. So I propose to degrade this message to a debug > message. > > Signed-off-by: Jean Delvare > Cc: Hans de Goede Looks good to me Acked-by: Hans de Goede > --- > drivers/hwmon/f71882fg.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > --- linux-2.6.29-rc2.orig/drivers/hwmon/f71882fg.c 2009-01-11 10:57:18.000000000 +0100 > +++ linux-2.6.29-rc2/drivers/hwmon/f71882fg.c 2009-01-19 20:11:16.000000000 +0100 > @@ -1872,7 +1872,7 @@ static int __init f71882fg_find(int sioa > > devid = superio_inw(sioaddr, SIO_REG_MANID); > if (devid != SIO_FINTEK_ID) { > - printk(KERN_INFO DRVNAME ": Not a Fintek device\n"); > + pr_debug(DRVNAME ": Not a Fintek device\n"); > goto exit; > } > > > _______________________________________________ lm-sensors mailing list lm-sensors@lm-sensors.org http://lists.lm-sensors.org/mailman/listinfo/lm-sensors