All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jan Kiszka <jan.kiszka@siemens.com>
To: qemu-devel@nongnu.org
Cc: Amit Shah <amit.shah@redhat.com>, aliguori@us.ibm.com
Subject: [Qemu-devel] Re: [PATCH 1/2] Print asynchronous notifications on request
Date: Tue, 20 Jan 2009 12:35:23 +0100	[thread overview]
Message-ID: <4975B6FB.6080302@siemens.com> (raw)
In-Reply-To: <1232448066-32209-1-git-send-email-amit.shah@redhat.com>

Amit Shah wrote:
> This patch adds the ability to selectively enable asynchronous notifications
> from individual qemu subsystems by a new 'notify' monitor command.
> 
> This is helpful for programs currently parsing monitor output.
> 
> A sample invocation will look like this:
> 
> (qemu)
>     <vnc connection closed>
> (qemu) notify vnc on
>     <vnc connection closed>
> (qemu) # VNC: Closing down connection 127.0.0.1:1
> 
> Notice that the output is prefixed by '#'. Also, it will appear on the
> line that has '(qemu) ' already output on it.

I understand the need, but the result looks a bit ugly, at least to
humans forced to parse it. If you get this while in the middle of type a
command... Moreover, is it impossible that such an async notification is
issued while some other subsystem is already dumping a multi-line
message to the monitor (using multiple prints)? That would be really
problematic.

But if this approach is merged, then I would really say we need
separately configurable monitor terminals, and notify should then only
affect the issuing one. However, my feeling is that a real
machine-dedicated and easily processable channel would be better suited
for this use case.

Jan

-- 
Siemens AG, Corporate Technology, CT SE 2
Corporate Competence Center Embedded Linux

  parent reply	other threads:[~2009-01-20 11:35 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-01-20 10:41 [Qemu-devel] [PATCH 1/2] Print asynchronous notifications on request Amit Shah
2009-01-20 10:41 ` [Qemu-devel] [PATCH 2/2] vnc: Use async notifications for closing down messages Amit Shah
2009-01-20 11:35 ` Jan Kiszka [this message]
2009-01-20 12:56   ` [Qemu-devel] Re: [PATCH 1/2] Print asynchronous notifications on request Avi Kivity
2009-01-20 13:32   ` Amit Shah
2009-01-20 15:27     ` Jan Kiszka
2009-01-20 20:42 ` Anthony Liguori

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4975B6FB.6080302@siemens.com \
    --to=jan.kiszka@siemens.com \
    --cc=aliguori@us.ibm.com \
    --cc=amit.shah@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.