From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with archive (Exim 4.43)
	id 1LPQ7L-0004Vh-DO
	for mharc-grub-devel@gnu.org; Tue, 20 Jan 2009 18:34:47 -0500
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1LPQ7J-0004U9-HL
	for grub-devel@gnu.org; Tue, 20 Jan 2009 18:34:45 -0500
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1LPQ7I-0004Tk-5g
	for grub-devel@gnu.org; Tue, 20 Jan 2009 18:34:45 -0500
Received: from [199.232.76.173] (port=39543 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1LPQ7I-0004Tg-07
	for grub-devel@gnu.org; Tue, 20 Jan 2009 18:34:44 -0500
Received: from eta-ori.net ([91.121.142.51]:51798 helo=orion.eta-ori.net)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <impulze@impulze.org>) id 1LPQ7H-0002cC-KL
	for grub-devel@gnu.org; Tue, 20 Jan 2009 18:34:43 -0500
Received: by orion.eta-ori.net (Postfix, from userid 1006)
	id 321982E581D; Wed, 21 Jan 2009 00:34:37 +0100 (CET)
Received: from [IPv6:2001:6f8:10ae:0:217:31ff:fe81:8c8]
	(istari.kleinerfeigling.org [IPv6:2001:6f8:10ae:0:217:31ff:fe81:8c8])
	by orion.eta-ori.net (Postfix) with ESMTPSA id 6279C2E5802
	for <grub-devel@gnu.org>; Wed, 21 Jan 2009 00:34:36 +0100 (CET)
Message-ID: <49765EE8.4050007@impulze.org>
Date: Wed, 21 Jan 2009 00:31:52 +0100
From: Daniel Mierswa <impulze@impulze.org>
User-Agent: Thunderbird 2.0.0.19 (X11/20090103)
MIME-Version: 1.0
To: grub-devel@gnu.org
X-Enigmail-Version: 0.95.7
OpenPGP: id=ADF32F97
Content-Type: multipart/mixed; boundary="------------090607000108020905030001"
X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6 (newer, 2)
Subject: [PATCH] Bug in UUID determiniation in fs/fat.c
X-BeenThere: grub-devel@gnu.org
X-Mailman-Version: 2.1.5
Precedence: list
Reply-To: The development of GRUB 2 <grub-devel@gnu.org>
List-Id: The development of GRUB 2 <grub-devel.gnu.org>
List-Unsubscribe: <http://lists.gnu.org/mailman/listinfo/grub-devel>,
	<mailto:grub-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/grub-devel>
List-Post: <mailto:grub-devel@gnu.org>
List-Help: <mailto:grub-devel-request@gnu.org?subject=help>
List-Subscribe: <http://lists.gnu.org/mailman/listinfo/grub-devel>,
	<mailto:grub-devel-request@gnu.org?subject=subscribe>
X-List-Received-Date: Tue, 20 Jan 2009 23:34:45 -0000

This is a multi-part message in MIME format.
--------------090607000108020905030001
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: quoted-printable

I found that during playing with ls -a. The UUID needs to be
right-shifted 16 times since it's a 32bit value and we need two 16bit
values. :)

--=20
Mierswa, Daniel

If you still don't like it, that's ok: that's why I'm boss. I simply
know better than you do.
               --- Linus Torvalds, comp.os.linux.advocacy, 1996/07/22

--------------090607000108020905030001
Content-Type: text/plain;
 name="fs_fat_wrong_uuid.patch"
Content-Transfer-Encoding: quoted-printable
Content-Disposition: inline;
 filename="fs_fat_wrong_uuid.patch"

Index: fs/fat.c
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D
--- fs/fat.c	(revision 1952)
+++ fs/fat.c	(working copy)
@@ -841,7 +841,7 @@
   if (data)
     {
       *uuid =3D grub_malloc (sizeof ("xxxx-xxxx"));
-      grub_sprintf (*uuid, "%04x-%04x", (grub_uint16_t) (data->uuid >> 8=
),
+      grub_sprintf (*uuid, "%04x-%04x", (grub_uint16_t) (data->uuid >> 1=
6),
 		    (grub_uint16_t) data->uuid);
     }
   else

--------------090607000108020905030001--