All of lore.kernel.org
 help / color / mirror / Atom feed
From: Pablo Neira Ayuso <pablo@netfilter.org>
To: Patrick McHardy <kaber@trash.net>,
	Netfilter Development Mailinglist
	<netfilter-devel@vger.kernel.org>
Subject: Re: 2.6.28(.1) and netlink: scheduling while atomic
Date: Wed, 21 Jan 2009 11:59:31 +0100	[thread overview]
Message-ID: <49770013.4020807@netfilter.org> (raw)
In-Reply-To: <4976F0EB.8050806@trash.net>

Patrick McHardy wrote:
> Kövesdi György wrote:
>> The new netlink interface allows to add NAT directly to a conntrack
>> entry.
>> If it is used when the moudule nf-nat-ipv4 is not loaded in, it
>> results in crash:
>> BUG: scheduling while atomic
>> It is in the kernels 2.6.28 and 2.6.28.1 in the function
>> ctnetlink_parse_nat_setup(): it calls request_module() which causes
>> the problem. If the module is already loaded, then there is no problem.
> 
> Thanks for the report. Does this patch fix it?

Hm, this was introduced when we fixed the problem with race condition in
the conntrack creation :( It would be worth to pass it to 2.6.29-rc.

-- 
"Los honestos son inadaptados sociales" -- Les Luthiers

--
To unsubscribe from this list: send the line "unsubscribe netfilter-devel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

  parent reply	other threads:[~2009-01-21 10:59 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-01-21  9:29 2.6.28(.1) and netlink: scheduling while atomic Kövesdi György
2009-01-21  9:54 ` Patrick McHardy
2009-01-21 10:25   ` Kövesdi György
2009-01-21 10:59   ` Pablo Neira Ayuso [this message]
2009-01-21 11:02     ` Patrick McHardy

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=49770013.4020807@netfilter.org \
    --to=pablo@netfilter.org \
    --cc=kaber@trash.net \
    --cc=netfilter-devel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.