Re: [PATCH] Move smp_num_siblings to the per-cpu data

[Frank Van Der Linden <Frank.Vanderlinden@Sun.COM>]

Keir Fraser wrote:
> On 20/01/2009 23:36, "Frank van der Linden" <Frank.Vanderlinden@Sun.COM>
> wrote:
>
>   
>> Make the num_siblings CPU parameter per-CPU.
>>
>> While it is unlikely that a system has a different number of siblings
>> for different physical CPUs,  make this parameter per-CPU for
>> consistency, and deal with the (so far theoretical) case that this is
>> different per CPU package.
>>
>> Signed-off-by: Frank van der Linden <Frank.Vanderlinden@Sun.COM>
>>     
>
> It's a pretty odd thing to decide to knock together one day. Do you have an
> underlying near-term motive for adding this flexibility?
>
>  -- Keir
>
>
>   
I originally did this as part of an extension to the MCE support 
hypercall. We needed some detailed physical CPU information, plus some 
MSR info. When implementing this, and extracting infro from cpu_data[], 
I noticed the smp_num_siblings inconsistency, so I changed it.

The other changes will be submitted as a separate patch, after they've 
been discussed with AMD & Intel.

- Frank