Re: [PATCH 04/05] sata_mv: msi masking fix (v2)

[Tejun Heo <htejun@gmail.com>]

Mark Lord wrote:
> Mark Lord wrote:
>> Tejun Heo wrote:
>>> Mark Lord wrote:
>> ..
>>>> +    /* Enable message-switched interrupts, if requested */
>>>> +    if (msi && 0 == pci_enable_msi(pdev))
>>>> +        hpriv->hp_flags |= MV_HP_FLAG_MSI;
>>>
>>> I just don't like CONSTANT OP EXPRESSION construct.
>> ..
>>
>> Heh.. Myself, I would normally just write it this way:
>>
>>     if (msi && !pci_enable_msi(pdev))
>>
>> But the "coding correctness police" might point out that
>> it reads funny (negatives and all that).
>>
>> But whatever way Jeff likes it, really.
> ..
> 
> .. perhaps keeping in mind that every little nit-picky revision
> like that requires me to go back to the deities at Marvell for
> re-approval before I can again present it for your blessings here.

Hey, we can con the system then by you submitting the original patch
and me following up with a nit picking patch right away, so if
changing the patch is too much of a hassle, please just go ahead with
the current patch.  :-)

Thanks.

-- 
tejun