From: Marek Lindner <mareklindner@neomailbox.ch>
To: b.a.t.m.a.n@lists.open-mesh.org
Cc: Antonio Quartulli <antonio@meshcoding.com>
Subject: Re: [B.A.T.M.A.N.] [PATCH 2/2] batman-adv: prevent potential hlist double deletion
Date: Sun, 28 Jun 2015 22:11:21 +0800 [thread overview]
Message-ID: <4978967.ff90mneJLc@voltaire> (raw)
In-Reply-To: <55883B64.1050201@meshcoding.com>
[-- Attachment #1: Type: text/plain, Size: 781 bytes --]
On Monday, June 22, 2015 18:44:20 Antonio Quartulli wrote:
> On 21/06/15 18:30, Marek Lindner wrote:
> > The hlist_del_rcu() call in batadv_tt_global_size_mod() does not check
> > if the element still is part of the list prior to deletion. The atomic
> > list counter should prevent the worst but converting to
> > hlist_del_init_rcu() ensures the element can't be deleted more than
> > once.
> >
> > Signed-off-by: Marek Lindner <mareklindner@neomailbox.ch>
>
> Acked-by: Antonio Quartulli <antonio@meshcoding.com>
Applied in revision 4729a33.
> However, as discussed offline after Sven's suggestion in ticket #217,
> the entire if-loop still needs to be protected with the vlan_list_lock
> and not just its body.
I'll take care of that in a separate patch.
Regards,
Marek
[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 473 bytes --]
next prev parent reply other threads:[~2015-06-28 14:11 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-21 16:30 [B.A.T.M.A.N.] [PATCH 1/2] batman-adv: convert orig_node->vlan_list to hlist Marek Lindner
2015-06-21 16:30 ` [B.A.T.M.A.N.] [PATCH 2/2] batman-adv: prevent potential hlist double deletion Marek Lindner
2015-06-22 16:44 ` Antonio Quartulli
2015-06-28 14:11 ` Marek Lindner [this message]
2015-06-22 16:37 ` [B.A.T.M.A.N.] [PATCH 1/2] batman-adv: convert orig_node->vlan_list to hlist Antonio Quartulli
2015-06-28 14:09 ` Marek Lindner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4978967.ff90mneJLc@voltaire \
--to=mareklindner@neomailbox.ch \
--cc=antonio@meshcoding.com \
--cc=b.a.t.m.a.n@lists.open-mesh.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.