From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with archive (Exim 4.43) id 1LQ5zv-0004IT-4B for mharc-grub-devel@gnu.org; Thu, 22 Jan 2009 15:17:55 -0500 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1LQ5zt-0004IM-3e for grub-devel@gnu.org; Thu, 22 Jan 2009 15:17:53 -0500 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1LQ5zr-0004IA-Gf for grub-devel@gnu.org; Thu, 22 Jan 2009 15:17:52 -0500 Received: from [199.232.76.173] (port=54048 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1LQ5zr-0004I7-90 for grub-devel@gnu.org; Thu, 22 Jan 2009 15:17:51 -0500 Received: from mailout10.t-online.de ([194.25.134.21]:55198) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1LQ5zr-0002X2-0F for grub-devel@gnu.org; Thu, 22 Jan 2009 15:17:51 -0500 Received: from fwd03.aul.t-online.de by mailout10.sul.t-online.de with smtp id 1LQ5zn-0006f9-02; Thu, 22 Jan 2009 21:17:47 +0100 Received: from [10.3.2.2] (XLRzMiZeghiWzH-7lV5TfJMP4TJgDFopgAMg75QRhc55rXpF+c1bzDEX4dWKdExgil@[217.235.252.139]) by fwd03.aul.t-online.de with esmtp id 1LQ5z7-1PAEAy0; Thu, 22 Jan 2009 21:17:05 +0100 Message-ID: <4978D443.8020306@t-online.de> Date: Thu, 22 Jan 2009 21:17:07 +0100 From: Christian Franke User-Agent: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8.1.16) Gecko/20080702 SeaMonkey/1.1.11 MIME-Version: 1.0 To: grub-devel@gnu.org References: <49765551.1030408@t-online.de> In-Reply-To: <49765551.1030408@t-online.de> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-ID: XLRzMiZeghiWzH-7lV5TfJMP4TJgDFopgAMg75QRhc55rXpF+c1bzDEX4dWKdExgil X-TOI-MSGID: f67571d0-5bca-446f-bec2-5b0fea0a7ed1 X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6 (newer, 3) Subject: Re: [PATCH] (ata.mod) Fix read/write, improve status check X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: The development of GRUB 2 List-Id: The development of GRUB 2 List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 22 Jan 2009 20:17:53 -0000 Christian Franke wrote: > This patch fixes these open issues: >> >> - grub_pio_read/write() check the ERR bit without ensuring !BSY. >> - ata_read fails if (batch % size) == 0. >> - ata_write does not work at all, it uses the read cmd. >> Tested on several PC + Committed. Christian