From: Mike Christie <michaelc@cs.wisc.edu>
To: Herbert Xu <herbert@gondor.apana.org.au>
Cc: "Brandeburg, Jesse" <jesse.brandeburg@intel.com>,
netdev@vger.kernel.org, olaf.kirch@oracle.com, tgraf@suug.ch,
kkeil@suse.de, "David S. Miller" <davem@davemloft.net>
Subject: Re: [PANIC] lro + iscsi or lro + skb text search causes panic
Date: Thu, 22 Jan 2009 18:04:11 -0600 [thread overview]
Message-ID: <4979097B.4040108@cs.wisc.edu> (raw)
In-Reply-To: <20090122232131.GA22771@gondor.apana.org.au>
Herbert Xu wrote:
> On Thu, Jan 22, 2009 at 12:55:21PM -0800, Brandeburg, Jesse wrote:
>> I've filed this bugzilla a while ago.
>> http://bugzilla.kernel.org/show_bug.cgi?id=11804
>> now other customers are becoming interested as well
>
> Does this patch help?
>
> net: Fix frag_list handling in skb_seq_read
>
> The frag_list handling was broken ini skb_seq_read:
>
> 1) We didn't add the stepped offset when looking at the head
> are of fragments other than the first.
>
> 2) The frag index wasn't reset.
>
> This patch fixes both issues.
>
Without the patch I do not get the oops Jesse saw. The iscsi driver logs
in and I do not see a problem until running IO (scsi read commands). The
iscsi code thinks there is a missing packet at the iscsi level and
begins recovery at that level.
With the patch running against linus's git tree, my box locks up. You
cannot ping it. I do not get a oops or anything in the logs, and the
keyboard does not respond. I will try to get some oops output and more info.
next prev parent reply other threads:[~2009-01-23 0:05 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-01-22 20:55 [PANIC] lro + iscsi or lro + skb text search causes panic Brandeburg, Jesse
2009-01-22 22:49 ` Mike Christie
2009-01-23 4:22 ` Mike Christie
2009-01-23 4:29 ` Mike Christie
2009-01-26 5:34 ` David Miller
2009-01-22 23:21 ` Herbert Xu
2009-01-22 23:45 ` Brandeburg, Jesse
2009-01-23 0:04 ` Mike Christie [this message]
2009-01-26 5:32 ` David Miller
2009-01-26 22:30 ` Herbert Xu
2009-01-27 1:40 ` Brandeburg, Jesse
2009-01-27 3:01 ` Herbert Xu
2009-01-27 5:52 ` David Miller
2009-01-27 6:12 ` Mike Christie
[not found] ` <46A00B48CC54E4468EF6911F877AC4CA01EF2BC9@blrx3m10.blr.amer.dell.com>
2009-01-28 21:25 ` Herbert Xu
2009-01-30 0:13 ` David Miller
2009-01-26 20:54 ` Mike Christie
-- strict thread matches above, loose matches on Subject: below --
2009-01-28 12:36 Shyam_Iyer
2009-01-28 18:22 ` Mike Christie
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4979097B.4040108@cs.wisc.edu \
--to=michaelc@cs.wisc.edu \
--cc=davem@davemloft.net \
--cc=herbert@gondor.apana.org.au \
--cc=jesse.brandeburg@intel.com \
--cc=kkeil@suse.de \
--cc=netdev@vger.kernel.org \
--cc=olaf.kirch@oracle.com \
--cc=tgraf@suug.ch \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.