From mboxrd@z Thu Jan 1 00:00:00 1970 From: Oren Laadan Subject: Re: [PATCH] Reset pos in cr_write_pids() Date: Fri, 23 Jan 2009 18:08:10 -0500 Message-ID: <497A4DDA.4080408@cs.columbia.edu> References: <20090122051407.GA20039@us.ibm.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20090122051407.GA20039-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: containers-bounces-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org Errors-To: containers-bounces-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org To: Sukadev Bhattiprolu Cc: Containers List-Id: containers.vger.kernel.org Sukadev Bhattiprolu wrote: > Noticed this while reviewing the code in [v12] branch of your git tree. Thanks. Will fix. Oren. > > --- > From: Sukadev Bhattiprolu > Date: Wed, 21 Jan 2009 21:10:34 -0800 > Subject: [PATCH] Reset pos in cr_write_pids() > > If the number of tasks exceed CR_HDR_PIDS_CHUNK, pos must be reset > for a second iteration in the outer loop. > --- > checkpoint/checkpoint.c | 3 ++- > 1 files changed, 2 insertions(+), 1 deletions(-) > > diff --git a/checkpoint/checkpoint.c b/checkpoint/checkpoint.c > index fbcd9eb..3136850 100644 > --- a/checkpoint/checkpoint.c > +++ b/checkpoint/checkpoint.c > @@ -297,7 +297,7 @@ static int cr_write_pids(struct cr_ctx *ctx) > struct pid_namespace *ns; > struct task_struct *task; > struct task_struct **tasks_arr; > - int tasks_nr, n, ret = 0, pos = 0; > + int tasks_nr, n, ret = 0, pos; > > ns = ctx->root_nsproxy->pid_ns; > tasks_arr = ctx->tasks_arr; > @@ -306,6 +306,7 @@ static int cr_write_pids(struct cr_ctx *ctx) > hh = cr_hbuf_get(ctx, sizeof(*hh) * CR_HDR_PIDS_CHUNK); > > while (tasks_nr > 0) { > + pos = 0; > rcu_read_lock(); > for (n = min(tasks_nr, CR_HDR_PIDS_CHUNK); n; n--) { > task = tasks_arr[pos];