From mboxrd@z Thu Jan  1 00:00:00 1970
From: Jeremy Fitzhardinge <jeremy@goop.org>
Subject: Re: pv_ops dom0 kernel failure with ata_piix / irq
	problems
Date: Sat, 24 Jan 2009 16:59:48 -0800
Message-ID: <497BB984.9080803@goop.org>
References: <495BE5E1.40602@goop.org> <20090102064444.GN15052@edu.joroinen.fi>
	<20090109174006.GR15052@edu.joroinen.fi>
	<f4527be0901091301p43c8db4bncd02daed4d6755b5@mail.gmail.com>
	<20090122194645.GJ15052@edu.joroinen.fi>
	<4978D5BE.8090601@goop.org>
	<20090124140930.GP15052@edu.joroinen.fi>
	<20090124145844.GQ15052@edu.joroinen.fi>
	<497B64B8.5040709@goop.org>
	<20090124201702.GR15052@edu.joroinen.fi>
	<20090124234920.GS15052@edu.joroinen.fi>
Mime-Version: 1.0
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: quoted-printable
Return-path: <xen-devel-bounces@lists.xensource.com>
In-Reply-To: <20090124234920.GS15052@edu.joroinen.fi>
List-Unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xensource.com>
List-Help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-Subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
Sender: xen-devel-bounces@lists.xensource.com
Errors-To: xen-devel-bounces@lists.xensource.com
To: =?ISO-8859-1?Q?Pasi_K=E4rkk=E4inen?= <pasik@iki.fi>
Cc: Todd Deshane <deshantm@gmail.com>, Andrew Lyon <andrew.lyon@gmail.com>, xen-devel@lists.xensource.com
List-Id: xen-devel@lists.xenproject.org

Pasi K=E4rkk=E4inen wrote:
> rc =3D devm_request_irq(dev, ATA_PRIMARY_IRQ(pdev), irq_handler, IRQF_S=
HARED, drv_name, host);
> if (rc)
> 	goto out;
>
> and ports names never get assigned because that "goto out;" is executed=
.
>
> So.. Any ideas why devm_request_irq() fails?=20


Good question.  Will need to pick through

Hm, wonder if its something to do with the handling of the legacy irqs:

ata_pci_sff_activate_host: pci_read_config_byte()
ata_pci_sff_activate_host: if (!devres_open_group(dev, NULL, GFP_KERNEL))
ata_pci_sff_activate_host: if (!legacy_mode && pdev->irq)
ata_pci_sff_activate_host: legacy_mode
ata_pci_sff_activate_host: port 0 not dummy: devm_request_irq()
ata_pci_sff_activate_host: non-legacy-mode irq: 30
ata_pci_sff_activate_host: requesting ATA_PRIMARY_IRQ(pdev) irq: 14
ata_pci_sff_activate_host: devm_request_irq() returned !=3D 0, goto out
ata_pci_sff_activate_host: out
ata_pci_sff_activate_host: devres_release_group()
ata_pci_sff_activate_host: end, returning


    J