From: Larry Finger <Larry.Finger@lwfinger.net>
To: Hauke Mehrtens <hauke@hauke-m.de>
Cc: "John W. Linville" <linville@tuxdriver.com>,
Herton Ronaldo Krzesinski <herton@mandriva.com.br>,
Hin-Tak Leung <htl10@users.sourceforge.net>,
barreyromartin@gmail.com, linux-wireless@vger.kernel.org
Subject: [RFT V2] rtl8187: Fix OFDM power settings for RTL8187L
Date: Sun, 25 Jan 2009 21:19:15 -0600 [thread overview]
Message-ID: <497D2BB3.9000002@lwfinger.net> (raw)
In-Reply-To: <497B05AF.5050701@hauke-m.de>
Hauke,
Please apply this patch on top of current wireless-testing, or
compat-wireless.
V1 only did one of the two kinds of radios.
Larry
====================
After reports of poor performance, a review of the latest vendor
driver (rtl8187_linux_26.1025.0328.2007) for RTL8187L devices was
undertaken.
A difference was found in the code used to index the OFDM power
tables. When the Linux driver was changed, my unit works at a much
greater range than before.
Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
---
Index: wireless-testing/drivers/net/wireless/rtl818x/rtl8187_rtl8225.c
===================================================================
--- wireless-testing.orig/drivers/net/wireless/rtl818x/rtl8187_rtl8225.c
+++ wireless-testing/drivers/net/wireless/rtl818x/rtl8187_rtl8225.c
@@ -285,6 +285,10 @@ static void rtl8225_rf_set_tx_power(stru
ofdm_power = priv->channels[channel - 1].hw_value >> 4;
cck_power = min(cck_power, (u8)11);
+ if (ofdm_power > (u8)15)
+ ofdm_power = 25;
+ else
+ ofdm_power += 10;
ofdm_power = min(ofdm_power, (u8)35);
rtl818x_iowrite8(priv, &priv->map->TX_GAIN_CCK,
@@ -536,7 +540,10 @@ static void rtl8225z2_rf_set_tx_power(st
cck_power += priv->txpwr_base & 0xF;
cck_power = min(cck_power, (u8)35);
- ofdm_power = min(ofdm_power, (u8)15);
+ if (ofdm_power > (u8)15)
+ ofdm_power = 25;
+ else
+ ofdm_power += 10;
ofdm_power += priv->txpwr_base >> 4;
ofdm_power = min(ofdm_power, (u8)35);
next prev parent reply other threads:[~2009-01-26 3:19 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-01-23 0:03 [PATCH] rtl8187: Fix driver to return TX retry info for RTL8187L Larry Finger
2009-01-23 15:07 ` Hauke Mehrtens
2009-01-23 15:31 ` John W. Linville
2009-01-24 12:12 ` Hauke Mehrtens
2009-01-24 17:45 ` Larry Finger
2009-01-25 16:55 ` Larry Finger
2009-01-26 1:36 ` [RFT] rtl8187: Fix OFDM power settings " Larry Finger
2009-01-26 3:19 ` Larry Finger [this message]
2009-01-27 19:24 ` [RFT V2] " Hauke Mehrtens
2009-01-27 19:41 ` Hin-Tak Leung
2009-01-27 20:00 ` Larry Finger
2009-01-30 21:28 ` Hauke Mehrtens
2009-01-23 15:34 ` [PATCH] rtl8187: Fix driver to return TX retry info " Larry Finger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=497D2BB3.9000002@lwfinger.net \
--to=larry.finger@lwfinger.net \
--cc=barreyromartin@gmail.com \
--cc=hauke@hauke-m.de \
--cc=herton@mandriva.com.br \
--cc=htl10@users.sourceforge.net \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.