All of lore.kernel.org
 help / color / mirror / Atom feed
From: Patrick McHardy <kaber@trash.net>
To: Christoph Paasch <christoph.paasch@student.uclouvain.be>
Cc: netfilter-devel@vger.kernel.org
Subject: Re: nf_conntrack_proto_generic, assigned to 0
Date: Mon, 26 Jan 2009 14:19:33 +0100	[thread overview]
Message-ID: <497DB865.8050003@trash.net> (raw)
In-Reply-To: <200901241622.36634.christoph.paasch@student.uclouvain.be>

Christoph Paasch wrote:
> Hi,
> 
> while reading through the source-code I remarked, that for the generic l4 
> protocol handler (nf_conntrack_proto_generic.c)  the protocol number 0 is 
> used. While linux/in.h defines IPPROTO_IP = 0 (and says "a dummy protocol for 
> tcp", whatever that may mean), in net/ipv6.h, the protocol 0 is used for the 
> hop-by-hop header. And as IANA states, 0 is assigned to the IPv6 Hop-by-hop 
> option.
> 
> Even, if netfilter doesn't tracks the hop-by-hop protocol, it shouldn't use 
> this number for the generic protocol handler, because this might be confusing.
> In my opinion, 255 should be used, which is assigned as "Reserved" by IANA.
> 
> What do you think?

It doesn't make a difference currently since in both cases we'd use
generic for HBH. But I think you're suggestion makes sense, could
you send a patch for this?

  reply	other threads:[~2009-01-26 13:19 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-01-24 15:22 nf_conntrack_proto_generic, assigned to 0 Christoph Paasch
2009-01-26 13:19 ` Patrick McHardy [this message]
2009-01-26 14:57   ` [PATCH] netfilter: changed generic l4 protocol number Christoph Paasch
2009-01-26 15:15     ` Patrick McHardy

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=497DB865.8050003@trash.net \
    --to=kaber@trash.net \
    --cc=christoph.paasch@student.uclouvain.be \
    --cc=netfilter-devel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.