From: Jake Goulding <goulding@vivisimo.com>
To: Johannes Schindelin <Johannes.Schindelin@gmx.de>
Cc: git@vger.kernel.org, gitster@pobox.com
Subject: Re: [PATCH 2/3] Make has_commit non-static
Date: Mon, 26 Jan 2009 14:20:30 -0500 [thread overview]
Message-ID: <497E0CFE.4080702@vivisimo.com> (raw)
In-Reply-To: <alpine.DEB.1.00.0901261637300.25749@intel-tinevez-2-302>
Johannes Schindelin wrote:
> Hi,
>
> On Mon, 26 Jan 2009, Jake Goulding wrote:
>
>> Moving has_commit from branch to a common location in preparation for
>> using it in tag. Renaming it to commit_has_any_in_commit_list to be more
>> unique.
>
> I feel like bike-shedding for a change, and I'd also like to prove that
> not all Germans like long names:
>
> is_ancestor_of_any()
>
> Hmm?
I assume that this means that the rest of the code/logic is fine? :-D
I'll change this (I don't have any attachment to one name or the other),
then it should be good to go!
-Jake
next prev parent reply other threads:[~2009-01-26 19:21 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-01-26 14:13 [PATCH 1/3] Make opt_parse_with_commit non-static Jake Goulding
2009-01-26 14:13 ` [PATCH 2/3] Make has_commit non-static Jake Goulding
2009-01-26 14:13 ` [PATCH 3/3] Add --contains flag to git tag Jake Goulding
2009-01-26 15:38 ` [PATCH 2/3] Make has_commit non-static Johannes Schindelin
2009-01-26 19:20 ` Jake Goulding [this message]
2009-01-26 20:06 ` Junio C Hamano
2009-01-26 20:38 ` Johannes Schindelin
2009-01-28 20:36 ` Junio C Hamano
2009-02-03 15:08 ` Jake Goulding
[not found] <1232671630-19683-1-git-send-email-goulding@vivisimo.com>
2009-01-23 0:48 ` Jake Goulding
2009-01-23 1:13 ` Junio C Hamano
2009-01-23 22:41 ` Jake Goulding
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=497E0CFE.4080702@vivisimo.com \
--to=goulding@vivisimo.com \
--cc=Johannes.Schindelin@gmx.de \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.