All of lore.kernel.org
 help / color / mirror / Atom feed
From: Patrick McHardy <kaber@trash.net>
To: Eric Leblond <eric@inl.fr>
Cc: yasuyuki.kozakai@toshiba.co.jp, netfilter-devel@vger.kernel.org
Subject: Re: [PATCH] netfilter: don't track ICMPv6 negotiation message.
Date: Tue, 27 Jan 2009 15:57:08 +0100	[thread overview]
Message-ID: <497F20C4.3090606@trash.net> (raw)
In-Reply-To: <1233053715-30398-1-git-send-email-eric@inl.fr>

Eric Leblond wrote:
> This patch removes connection tracking handling for ICMPv6 messages
> related to Stateless Address Autoconfiguration, MLD, and MLDv2. They
> can not be tracked because they are massively using multicast (on
> pre-defined address). But they are not invalid and should not be
> detected as such.

Applied, thanks Eric.

> +	type = icmp6h->icmp6_type - 130;
> +	if (type >= 0 && type < sizeof(noct_valid_new)
> +	    && noct_valid_new[type]) {

I've made a small cosmetic change here and moved the && to the
first line. I'm slowly trying to get rid of the inconsistent
operator placement whenever we touch some code.


  reply	other threads:[~2009-01-27 14:57 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <200901271007.n0RA78k6023294@toshiba.co.jp>
2009-01-27 10:55 ` [PATCH] netfilter: don't track ICMPv6 negotiation message Eric Leblond
2009-01-27 14:57   ` Patrick McHardy [this message]
2009-02-06 10:30   ` Christoph Paasch
2009-02-08 17:35     ` Eric Leblond
2009-02-09 17:39       ` Christoph Paasch
2009-01-23 11:10 [PATCH 0/2] IPv6 conntrack support for neighbour discovery Yasuyuki KOZAKAI
2009-01-24 10:32 ` [PATCH] netfilter: don't track ICMPv6 negotiation message Eric Leblond
2009-01-27 10:07   ` Yasuyuki KOZAKAI

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=497F20C4.3090606@trash.net \
    --to=kaber@trash.net \
    --cc=eric@inl.fr \
    --cc=netfilter-devel@vger.kernel.org \
    --cc=yasuyuki.kozakai@toshiba.co.jp \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.