From: Gilles Chanteperdrix <gilles.chanteperdrix@xenomai.org>
To: Jan Kiszka <jan.kiszka@domain.hid>
Cc: xenomai-core <xenomai@xenomai.org>
Subject: Re: [Xenomai-core] [PATCH] xnpipe: Fix minor number management
Date: Tue, 27 Jan 2009 17:14:27 +0000 [thread overview]
Message-ID: <497F40F3.3010801@domain.hid> (raw)
In-Reply-To: <497F3E29.6050303@domain.hid>
Jan Kiszka wrote:
> This is an attempt to fix the bugs found in the minor number management:
> - changing the bitmap requires atomic operations
> - clrbits/setbits work against xnarch_atomic_t, and that is only 32 bit
> wide on x86-64
I think we should rather fix xnarch_atomic_t to be the size of a long on
x86-64, than having to cope with xnarch_atomic_t of various sizes in the
code (there are probably other places where we depend on the size of
xnarch_atomic_t).
As for the find_first_bit, why not simply taking the nklock
xnpipe_minor_free ? This is a first masking section, so this should not
matter a lot.
--
Gilles.
next prev parent reply other threads:[~2009-01-27 17:14 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-01-27 17:02 [Xenomai-core] [PATCH] xnpipe: Fix minor number management Jan Kiszka
2009-01-27 17:14 ` Gilles Chanteperdrix [this message]
2009-01-27 17:19 ` Gilles Chanteperdrix
2009-01-27 17:27 ` Jan Kiszka
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=497F40F3.3010801@domain.hid \
--to=gilles.chanteperdrix@xenomai.org \
--cc=jan.kiszka@domain.hid \
--cc=xenomai@xenomai.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.