From: Manu Abraham <abraham.manu@gmail.com>
To: Jan Engelhardt <jengelh@medozas.de>
Cc: linux-media@vger.kernel.org
Subject: Re: saa716x compile warnings
Date: Wed, 28 Jan 2009 04:43:34 +0400 [thread overview]
Message-ID: <497FAA36.7060304@gmail.com> (raw)
In-Reply-To: <alpine.LSU.2.00.0901060621130.18397@fbirervta.pbzchgretzou.qr>
Jan Engelhardt wrote:
> Hi,
>
>
> I noticed in a forum post that the saa716x driver spews warnings on
> x86_64:
>
> http://www.linux-club.de/viewtopic.php?f=41&t=100240
>
> /home/johnny/Documents/saa716x-e9cc5826649c/v4l/saa716x_dma.c:129:
> warning: cast from pointer to integer of different size
>
> as I look into the code (tip just moments ago), that seems to be largely
> true:
>
> /* align memory to page */
> dmabuf->mem_virt = (void *) PAGE_ALIGN (((u32) dmabuf->mem_virt_noalign));
>
> I always recommend building it not only on x86 to catch such errors.
> Truncating to (u32) is likely to be wrong for 64-bit systems!
>
Fixed now.
Thanks,
Manu
parent reply other threads:[~2009-01-28 0:43 UTC|newest]
Thread overview: expand[flat|nested] mbox.gz Atom feed
[parent not found: <alpine.LSU.2.00.0901060621130.18397@fbirervta.pbzchgretzou.qr>]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=497FAA36.7060304@gmail.com \
--to=abraham.manu@gmail.com \
--cc=jengelh@medozas.de \
--cc=linux-media@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.