All of lore.kernel.org
 help / color / mirror / Atom feed
From: Heiko Schocher <hs@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 12/31] 82xx, mgcoge: corrected wrong flash sizes
Date: Wed, 28 Jan 2009 13:54:40 +0100	[thread overview]
Message-ID: <49805590.5040405@denx.de> (raw)
In-Reply-To: <20090128120154.53390832E416@gemini.denx.de>

Hello Wolfgang,

Wolfgang Denk wrote:
> In message <498027D6.3070600@denx.de> you wrote:
>> flash size of mgcoge corrected
>>  boot to  4M (was 32)
>>  cfg  to 32M (was 64)
>>
>> Signed-off-by: Thomas Herzmann <thomas.herzmann@keymile.com>
>> Signed-off-by: Heiko Schocher <hs@denx.de>
>> ---
>>  include/configs/mgcoge.h |    4 ++--
>>  1 files changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/include/configs/mgcoge.h b/include/configs/mgcoge.h
>> index a754f0b..f307382 100644
>> --- a/include/configs/mgcoge.h
>> +++ b/include/configs/mgcoge.h
>> @@ -99,14 +99,14 @@
>>
>>  #define CONFIG_SYS_SDRAM_BASE		0x00000000
>>  #define CONFIG_SYS_FLASH_BASE		0xFE000000
>> -#define CONFIG_SYS_FLASH_SIZE		32
>> +#define CONFIG_SYS_FLASH_SIZE		4
> 
> That's broken. The flash size should never be defined. Why don;t you
> use auto-detection as U-Boot was designed for?

I use the CFI driver ... have to check for what this defines are
used (Hopefully they are no more used).

Argh... i used it.

I change this.

thanks
Heiko
-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany

      reply	other threads:[~2009-01-28 12:54 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-01-28  9:39 [U-Boot] [PATCH 12/31] 82xx, mgcoge: corrected wrong flash sizes Heiko Schocher
2009-01-28 12:01 ` Wolfgang Denk
2009-01-28 12:54   ` Heiko Schocher [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=49805590.5040405@denx.de \
    --to=hs@denx.de \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.