From: Wayne Boyer <wayneb@linux.vnet.ibm.com>
To: James Bottomley <James.Bottomley@HansenPartnership.com>
Cc: linux-scsi@vger.kernel.org
Subject: Re: [PATCH 2/2] ipr: add message to error table
Date: Wed, 28 Jan 2009 08:24:50 -0800 [thread overview]
Message-ID: <498086D2.8050405@linux.vnet.ibm.com> (raw)
In-Reply-To: <1232893083.4586.2.camel@localhost.localdomain>
James Bottomley wrote:
> On Fri, 2009-01-23 at 09:17 -0800, Wayne Boyer wrote:
>> Adds a message to the error table for an error that wasn't previously handled.
>>
>> Signed-off-by: Wayne Boyer <wayneb@linux.vnet.ibm.com>
>> ---
>>
>> drivers/scsi/ipr.c | 2 ++
>> 1 file changed, 2 insertions(+)
>>
>> Index: linux-2.6/drivers/scsi/ipr.c
>> ===================================================================
>> --- linux-2.6.orig/drivers/scsi/ipr.c 2009-01-22 15:50:59.000000000 -0800
>> +++ linux-2.6/drivers/scsi/ipr.c 2009-01-23 08:55:23.000000000 -0800
>> @@ -354,6 +354,8 @@
>> "9076: Configuration error, missing remote IOA"},
>> {0x06679100, 0, IPR_DEFAULT_LOG_LEVEL,
>> "4050: Enclosure does not support a required multipath function"},
>> + {0x06690000, 0, IPR_DEFAULT_LOG_LEVEL,
>> + "4070: Logically bad written to device"},
>
> Neither from the change log nor from the actual text can I tell what the
> problem is ... is there a word missing (like block or sector)?
>
After some discussion, I've come up with a more descriptive message and
better change log. Updated patch below...
> James
>
Adds a message to the error table for an error that wasn't previously handled.
In some cases the I/O Adapter will detect an error condition and mark a block
as "logically bad".
Signed-off-by: Wayne Boyer <wayneb@linux.vnet.ibm.com>
---
drivers/scsi/ipr.c | 2 ++
1 file changed, 2 insertions(+)
Index: linux-2.6/drivers/scsi/ipr.c
===================================================================
--- linux-2.6.orig/drivers/scsi/ipr.c 2009-01-26 12:29:01.000000000 -0800
+++ linux-2.6/drivers/scsi/ipr.c 2009-01-27 14:32:08.000000000 -0800
@@ -354,6 +354,8 @@
"9076: Configuration error, missing remote IOA"},
{0x06679100, 0, IPR_DEFAULT_LOG_LEVEL,
"4050: Enclosure does not support a required multipath function"},
+ {0x06690000, 0, IPR_DEFAULT_LOG_LEVEL,
+ "4070: Logically bad block written on device"},
{0x06690200, 0, IPR_DEFAULT_LOG_LEVEL,
"9041: Array protection temporarily suspended"},
{0x06698200, 0, IPR_DEFAULT_LOG_LEVEL,
--
Wayne Boyer
IBM - Beaverton, Oregon
LTC S/W Development - eServerIO
(503) 578-5236, T/L 775-5236
prev parent reply other threads:[~2009-01-28 16:24 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20090123165823.748742817@linux.vnet.ibm.com>
2009-01-23 17:17 ` [PATCH 1/2] ipr: add MSI support Wayne Boyer
2009-01-23 18:39 ` Brian King
2009-01-23 17:17 ` [PATCH 2/2] ipr: add message to error table Wayne Boyer
2009-01-23 18:39 ` Brian King
2009-01-25 14:18 ` James Bottomley
2009-01-28 16:24 ` Wayne Boyer [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=498086D2.8050405@linux.vnet.ibm.com \
--to=wayneb@linux.vnet.ibm.com \
--cc=James.Bottomley@HansenPartnership.com \
--cc=linux-scsi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.