All of lore.kernel.org
 help / color / mirror / Atom feed
From: "H. Peter Anvin" <hpa@zytor.com>
To: Jeremy Fitzhardinge <jeremy@goop.org>
Cc: Ingo Molnar <mingo@elte.hu>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 1/3] x86: unify asm/io.h: IO_SPACE_LIMIT
Date: Wed, 28 Jan 2009 22:36:57 -0800	[thread overview]
Message-ID: <49814E89.6090802@zytor.com> (raw)
In-Reply-To: <4980ED5F.30904@goop.org>

Hi Jeremy,

I applied patch #1 to tip:x86/cleanups, however, patch #2 and #3 are
identical... did you mean to do something different here?

Furthermore, please provide an actual description (and preferrably an
Impact: line) with your patches.  In particular, when unifying code that
is identical between 32 and 64 bits, please specify this in the
description (e.g. "unified functions X and Y which were already
identical between 32 and 64 bits"), so we know why there isn't a
preceeding patch to remove the remaining differences.

Thanks,

	-hpa

-- 
H. Peter Anvin, Intel Open Source Technology Center
I work for Intel.  I don't speak on their behalf.


  reply	other threads:[~2009-01-29  6:40 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-01-28 23:42 [PATCH 1/3] x86: unify asm/io.h: IO_SPACE_LIMIT Jeremy Fitzhardinge
2009-01-29  6:36 ` H. Peter Anvin [this message]
2009-01-29  9:45   ` Jeremy Fitzhardinge

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=49814E89.6090802@zytor.com \
    --to=hpa@zytor.com \
    --cc=jeremy@goop.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@elte.hu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.