All of lore.kernel.org
 help / color / mirror / Atom feed
From: Tejun Heo <htejun@gmail.com>
To: Jeremy Fitzhardinge <jeremy@goop.org>
Cc: Brian Gerst <brgerst@gmail.com>, Ingo Molnar <mingo@elte.hu>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	Gerd Hoffmann <kraxel@redhat.com>
Subject: Re: unified percpu stuff
Date: Thu, 29 Jan 2009 20:01:19 +0900	[thread overview]
Message-ID: <49818C7F.1030202@gmail.com> (raw)
In-Reply-To: <49818842.5020004@goop.org>

Jeremy Fitzhardinge wrote:
> Tejun Heo wrote:
>> The current tj-percpu[1] contains Brian's commit which consolidates
>> load_gs_base() into switch_to_new_gdt(), 
> 
> There's a bit of a bootstrap problem using switch_to_new_gdt() on the
> boot CPU: it uses smp_processor_id, which ends up doing a
> percpu_read(cpu_number), which naturally crashes because %gs isn't set
> up yet.  Perhaps switch_to_new_gdt() should take the cpu number as a
> parameter (or at least a __switch_to_new_gdt variant which does).

Please feel free to submit a patch.  It being a pretty low level
function, I think it would be better to convert it to take cpu_number.

Thanks.

-- 
tejun

  reply	other threads:[~2009-01-29 11:01 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-01-27  1:12 unified percpu stuff Jeremy Fitzhardinge
2009-01-27  4:17 ` Tejun Heo
2009-01-29 10:43   ` Jeremy Fitzhardinge
2009-01-29 11:01     ` Tejun Heo [this message]
2009-01-29 13:43     ` [PATCH] x86: pass in cpu number to switch_to_new_gdt() Brian Gerst
2009-01-29 21:36       ` Jeremy Fitzhardinge
2009-01-29 21:36       ` [PATCH 1/2] x86: split loading percpu segments from loading gdt Jeremy Fitzhardinge
2009-01-29 21:36       ` [PATCH 2/2] xen: setup percpu data pointers Jeremy Fitzhardinge
2009-01-30  8:50         ` Tejun Heo
2009-01-30  8:50       ` [PATCH] x86: pass in cpu number to switch_to_new_gdt() Tejun Heo
2009-01-27  5:57 ` unified percpu stuff Brian Gerst
2009-01-27  7:24   ` Jeremy Fitzhardinge
2009-01-27 12:35     ` Brian Gerst
2009-01-27 17:50       ` Jeremy Fitzhardinge
2009-01-27 19:07         ` Brian Gerst

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=49818C7F.1030202@gmail.com \
    --to=htejun@gmail.com \
    --cc=brgerst@gmail.com \
    --cc=jeremy@goop.org \
    --cc=kraxel@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@elte.hu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.