Re: [PATCH] Fix infinite retry loop in IP-Config

[Benjamin ZORES <benjamin.zores@alcatel-lucent.fr>]

David Miller a écrit :
> From: Benjamin ZORES <benjamin.zores@alcatel-lucent.fr>
> Date: Wed, 28 Jan 2009 13:08:15 +0100
>
>   
>> Jarek Poplawski a écrit :
>>     
>>> On 28-01-2009 10:07, Benjamin ZORES wrote:
>>>   
>>>       
>>>> diff --git a/net/ipv4/ipconfig.c b/net/ipv4/ipconfig.c
>>>> index 42a0f3d..4911b81 100644
>>>> --- a/net/ipv4/ipconfig.c
>>>> +++ b/net/ipv4/ipconfig.c
>>>> @@ -1268,6 +1268,7 @@ __be32 __init root_nfs_parse_addr(char *name)
>>>>  static int __init ip_auto_config(void)
>>>>  {
>>>>  	__be32 addr;
>>>> +	 int retries = CONF_OPEN_RETRIES;
>>>>     
>>>>         
>>>  Doesn't it need "#ifdef IPCONFIG_DYNAMIC" to prevent a compiler
>>> warning? I guess you could add a "Signed-off-by:" line BTW.
>>>   
>>>       
>> You're perfectly right about this.
>> Attached an updated version of the patch.
>>     
>
> Patch applied, thank you.
Be my guest. Thanks to you.

Ben