From: "Jonas Flodén" <jonas.floden@gmail.com>
To: Charles Bailey <charles@hashpling.org>
Cc: git@vger.kernel.org
Subject: Re: [PATCH] Quick and dirty mergetool fix - take 2
Date: Fri, 30 Jan 2009 17:22:22 +0100 [thread overview]
Message-ID: <4983293E.9070401@gmail.com> (raw)
In-Reply-To: <1233332166-14300-1-git-send-email-charles@hashpling.org>
Charles Bailey wrote:
> ---
> git-mergetool.sh | 8 ++++----
> 1 files changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/git-mergetool.sh b/git-mergetool.sh
> index aefdca7..d495a6b 100755
> --- a/git-mergetool.sh
> +++ b/git-mergetool.sh
> @@ -131,7 +131,7 @@ checkout_staged_file () {
> tmpfile=$(expr "$(git checkout-index --temp --stage="$1" "$2")" : '\([^ ]*\) ')
>
> if test $? -eq 0 -a -n "$tmpfile" ; then
> - mv -- "$tmpfile" "$3"
> + mv -- "$(git rev-parse --show-cdup)$tmpfile" "$3"
> fi
> }
>
> @@ -161,9 +161,9 @@ merge_file () {
> local_mode=`git ls-files -u -- "$MERGED" | awk '{if ($3==2) print $1;}'`
> remote_mode=`git ls-files -u -- "$MERGED" | awk '{if ($3==3) print $1;}'`
>
> - base_present && checkout_staged_file 1 "$prefix$MERGED" "$BASE"
> - local_present && checkout_staged_file 2 "$prefix$MERGED" "$LOCAL"
> - remote_present && checkout_staged_file 3 "$prefix$MERGED" "$REMOTE"
> + base_present && checkout_staged_file 1 "$MERGED" "$BASE"
> + local_present && checkout_staged_file 2 "$MERGED" "$LOCAL"
> + remote_present && checkout_staged_file 3 "$MERGED" "$REMOTE"
>
> if test -z "$local_mode" -o -z "$remote_mode"; then
> echo "Deleted merge conflict for '$MERGED':"
Yes, I was just about to propose a similar patch.
This solution works for me!
You might want to remove $prefix from the top of the
file since it's not used any more.
Thanks!
// Jonas
prev parent reply other threads:[~2009-01-30 16:24 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-01-30 13:05 git mergetool from next not working in subdirectory Jonas Flodén
2009-01-30 13:50 ` Johannes Gilger
2009-01-30 14:06 ` Charles Bailey
2009-01-30 14:22 ` [PATCH] Quick and dirty mergetool fix Charles Bailey
2009-01-30 16:00 ` Jonas Flodén
2009-01-30 16:16 ` [PATCH] Quick and dirty mergetool fix - take 2 Charles Bailey
2009-01-30 16:18 ` Charles Bailey
2009-01-30 16:22 ` Jonas Flodén [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4983293E.9070401@gmail.com \
--to=jonas.floden@gmail.com \
--cc=charles@hashpling.org \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.