From: Sergei Shtylyov <sshtylyov@ru.mvista.com>
To: Alan Cox <alan@lxorguk.ukuu.org.uk>
Cc: Hugh Dickins <hugh@veritas.com>, Jeff Garzik <jgarzik@redhat.com>,
"Rafael J. Wysocki" <rjw@sisk.pl>,
linux-ide@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: 2.6.29-rc libata sff 32bit PIO regression
Date: Sat, 31 Jan 2009 19:57:17 +0300 [thread overview]
Message-ID: <498482ED.9090800@ru.mvista.com> (raw)
In-Reply-To: <20090131160601.5159579d@lxorguk.ukuu.org.uk>
Hello.
Alan Cox wrote:
>>> + if (pdev->device == PCI_DEVICE_ID_AMD_VIPER_7411) /* FIFO is broken */
>>> + fifo = 0;
>>> +
>>> + /* On the later chips the read prefetch bits become no-op bits */
>>> + pci_read_config_byte(pdev, 0x41, &r);
>>> + r &= ~fifobit[ap->port_no];
>>>
>>>
>> Why not:
>>
>> r &= ~fifo;
>>
>
> Because then it wouldn't clear the bits if they were set already and we
> wanted them off!
>
Ah, missed the modification of 'fifo'... :-<
MBR, Sergei
next prev parent reply other threads:[~2009-01-31 16:57 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-01-21 13:34 2.6.29-rc libata sff 32bit PIO regression Hugh Dickins
2009-01-21 20:11 ` Mikael Pettersson
2009-01-21 21:47 ` Alan Cox
2009-01-21 22:51 ` Sergei Shtylyov
2009-01-21 22:58 ` Alan Cox
2009-01-21 23:34 ` Sergei Shtylyov
2009-01-21 23:37 ` Sergei Shtylyov
2009-01-22 0:20 ` Sergei Shtylyov
2009-01-25 15:22 ` Alan Cox
2009-01-25 15:22 ` Alan Cox
2009-01-26 19:11 ` Alan Cox
2009-01-31 15:11 ` Sergei Shtylyov
2009-01-31 16:06 ` Alan Cox
2009-01-31 16:57 ` Sergei Shtylyov [this message]
2009-02-01 21:13 ` Hugh Dickins
2009-02-02 11:48 ` Sergei Shtylyov
2009-02-02 12:12 ` Hugh Dickins
2009-02-02 14:17 ` Sergei Shtylyov
2009-02-03 3:59 ` Jeff Garzik
2009-02-04 11:10 ` Sergei Shtylyov
2009-01-26 19:12 ` Alan Cox
2009-02-03 4:00 ` Jeff Garzik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=498482ED.9090800@ru.mvista.com \
--to=sshtylyov@ru.mvista.com \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=hugh@veritas.com \
--cc=jgarzik@redhat.com \
--cc=linux-ide@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rjw@sisk.pl \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.