Re: [ath5k-devel] [PATCH 5/5] ath5k: Update reset code

[Felix Fietkau <nbd@openwrt.org>]

Nick Kossifidis wrote:
>>> My intention is to reimplement hw_htoclock to account for half/quarter
>>> rate so it'll soon be
>>> clock = ath5k_hw_htoclock(1, channel->hw_value);
>> AFAIK Sam's HAL might have a bug there. If I remember correctly, the MAC
>> runs at the same clock speed with Half/Quarter rate.
>> It's done that way in the legacy HAL. Though there is a possibility of
>> it being hardware dependent, I'm pretty sure that it is that way at least
>> on 5413.
>>
> 
> Both HALs tweak clock this way on ar5212SetDeltaSlope on all chips. If
> clock depends on channel bandwidth for turbo it makes sense to also
> change on half/quarter rate operation.
Yeah, for the delta slope it may be the same, but not for the MAC, IMHO.
Check out ath_hal_mac_clks in the legacy HAL and Sam's HAL. I believe
the legacy HAL variant is correct in this case.

- Felix