From: Ping-Ke Shih <pkshih@realtek.com>
To: Vincent Schurink <spam@acio.nl>
Cc: "linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>
Subject: RE: [PATCH rtw-next v3] wifi: rtw89: set RA init rate level when the station RSSI is known
Date: Fri, 13 Nov 2026 08:24:39 +0000 [thread overview]
Message-ID: <4985719de8b5439e8484384ed52033e1@realtek.com> (raw)
In-Reply-To: <20261113080731.30155-1-spam@acio.nl>
Vincent Schurink <spam@acio.nl> wrote:
[...]
> @@ -747,14 +765,8 @@ void rtw89_phy_ra_assoc(struct rtw89_dev *rtwdev, struct rtw89_sta_link *rtwsta_
>
> rcu_read_unlock();
>
> - if (rssi > 40)
> - ra->init_rate_lv = 1;
> - else if (rssi > 20)
> - ra->init_rate_lv = 2;
> - else if (rssi > 1)
> - ra->init_rate_lv = 3;
> - else
> - ra->init_rate_lv = 0;
> + ra->init_rate_lv = rtw89_phy_ra_get_init_rate_lv(rtwsta_link);
> + rtwsta_link->ra_rssi_unknown = !ra->init_rate_lv;
Not only RSSI 0 but RSSI 1 can fall into this case, but I think it is harmless.
How about put into ra-> instead of rtwsta_link-> ?
Please put it on bottom with a comment like below, because the struct rtw89_ra_info
is a copy of H2C command (at initial version).
@@ -5235,6 +5235,8 @@ struct rtw89_ra_info {
u8 macid_msb:2;
u8 band:2; /* enum rtw89_band */
u8 is_new_dbgreg:1;
+ /* driver helpers */
+ bool rssi_unknown:1;
};
> ra->upd_all = 1;
> rtw89_debug(rtwdev, RTW89_DBG_RA,
> "ra assoc: macid = %d, mode = %d, bw = %d, nss = %d, lv = %d",
> --
> 2.53.0
next prev parent reply other threads:[~2026-11-13 8:24 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-13 8:07 [PATCH rtw-next v3] wifi: rtw89: set RA init rate level when the station RSSI is known Vincent Schurink
2026-11-13 8:24 ` Ping-Ke Shih [this message]
2026-11-13 15:34 ` V. S.
2026-11-15 3:05 ` Ping-Ke Shih
2026-11-15 11:59 ` V. S.
2026-11-16 0:41 ` Ping-Ke Shih
2026-11-16 7:48 ` Ping-Ke Shih
2026-11-16 8:22 ` V. S.
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4985719de8b5439e8484384ed52033e1@realtek.com \
--to=pkshih@realtek.com \
--cc=linux-wireless@vger.kernel.org \
--cc=spam@acio.nl \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.