All of lore.kernel.org
 help / color / mirror / Atom feed
From: Edward Shishkin <edward.shishkin@gmail.com>
To: Matthias Grobarek <UnclePain@gmx.de>
Cc: reiserfs-devel@vger.kernel.org
Subject: Re: Small fix for reiser4 compiling issue
Date: Sun, 01 Feb 2009 23:36:43 +0300	[thread overview]
Message-ID: <498607DB.7070000@gmail.com> (raw)
In-Reply-To: <4985FF0C.6050502@gmx.de>

Matthias Grobarek wrote:
> Hi,
>   
Hello.

> while playing around with my Gentoo system, I decided to switch to a hardened profile, including the usage of a kernel from the Hardened Gentoo
> project. This is a heavily patched kernel 2.6.28, but it doesn’t include reiser4 support, so I needed to create a custom one from it to include
> the reiser4 2.6.28 patchset. When I tried to compile this kernel, I got an error in one of the reiser4 files... and of course I forgot to note
> the error down, something about using implicit declaration of a function. Luckily, I could see a simple solution in the other filesystem drivers
> in the kernel, so I changed the erroneous reiser4 file accordingly and voilà, the kernel compiled.
>
> I’m not familar with creating patches and such, so I just give you the diff output. The file it’s referring to is:
> fs/reiser4/plugin/file/file_conversion.c
>
> 689c689
> <       page = __grab_cache_page(mapping, index);
> ---
>   
>>       page = grab_cache_page(mapping, index);
>>     
>
>   

Here  is the correct patch:
http://userweb.kernel.org/~akpm/mmotm/broken-out/fs-symlink-write_begin-allocation-context-fix-reiser4-fix.patch

Thanks,
Edward.

> I still haven’t tested the kernel, but the fact that it compiles is enough for me to believe it will work (just as reiser4 has been working for
> me flawlessly). Furthermore, I have absolutely no clue about kernel driver development, so I’m not sure what implications this change has.
>
> Regards,
>
>
> Matthias Grobarek
> --
> To unsubscribe from this list: send the line "unsubscribe reiserfs-devel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
>
>   

--
To unsubscribe from this list: send the line "unsubscribe reiserfs-devel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

      reply	other threads:[~2009-02-01 20:36 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-02-01 19:59 Small fix for reiser4 compiling issue Matthias Grobarek
2009-02-01 20:36 ` Edward Shishkin [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=498607DB.7070000@gmail.com \
    --to=edward.shishkin@gmail.com \
    --cc=UnclePain@gmx.de \
    --cc=reiserfs-devel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.