From: Pablo Neira Ayuso <pablo@netfilter.org>
To: Jan Engelhardt <jengelh@medozas.de>
Cc: kaber@trash.net,
Netfilter Developer Mailing List
<netfilter-devel@vger.kernel.org>, jamal <hadi@cyberus.ca>
Subject: Re: libxtables: prefix names and order it #2
Date: Sun, 01 Feb 2009 22:38:40 +0100 [thread overview]
Message-ID: <49861660.1070709@netfilter.org> (raw)
In-Reply-To: <49860C6C.8070805@netfilter.org>
Pablo Neira Ayuso wrote:
> Jan Engelhardt wrote:
>> diff --git a/ip6tables-restore.c b/ip6tables-restore.c
>> index a84c2e3..097711f 100644
>> --- a/ip6tables-restore.c
>> +++ b/ip6tables-restore.c
>> @@ -12,6 +12,7 @@
>>
>> #include <getopt.h>
>> #include <sys/errno.h>
>> +#include <stdbool.h>
>> #include <string.h>
>> #include <stdio.h>
>> #include <stdlib.h>
>
> Aie. I was reverting this C99-specific thing but then I have noticed
> that there's already one reference to it in the tree. I'm going to
> revert it.
>
> This break the compilation in many existing setups (like some of mine)
> that don't have the stdbool.h header. BTW, iptables is being compiled
> with gcc89 dialect, at least by now.
Forget this. gnu89 contains some c99 extensions like bool so this is
fine. I was confused by one problem spot in the compilation of iptables
in my setup. I have applied this patch. Thanks Jan.
--
"Los honestos son inadaptados sociales" -- Les Luthiers
next prev parent reply other threads:[~2009-02-01 21:38 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-01-27 14:01 libxtables: prefix names and order it #1 Jan Engelhardt
2009-01-27 14:11 ` libxtables: prefix names and order it #2 Jan Engelhardt
2009-01-27 14:23 ` libxtables: prefix names and order #3 Jan Engelhardt
2009-02-01 21:39 ` Pablo Neira Ayuso
2009-02-01 20:56 ` libxtables: prefix names and order it #2 Pablo Neira Ayuso
2009-02-01 21:38 ` Pablo Neira Ayuso [this message]
2009-01-27 14:19 ` libxtables: prefix names and order it #1 jamal
2009-01-27 14:29 ` jamal
2009-01-27 14:32 ` Jan Engelhardt
2009-01-27 14:36 ` Patrick McHardy
2009-01-30 4:52 ` Jan Engelhardt
2009-01-30 13:39 ` jamal
2009-02-01 21:17 ` Pablo Neira Ayuso
2009-02-01 20:52 ` Pablo Neira Ayuso
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=49861660.1070709@netfilter.org \
--to=pablo@netfilter.org \
--cc=hadi@cyberus.ca \
--cc=jengelh@medozas.de \
--cc=kaber@trash.net \
--cc=netfilter-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.