All of lore.kernel.org
 help / color / mirror / Atom feed
From: Andrew Walrond <andrew@walrond.org>
To: Jan Engelhardt <jengelh@medozas.de>
Cc: David Miller <davem@davemloft.net>,
	sam@ravnborg.org, linux-kernel@vger.kernel.org,
	netdev@vger.kernel.org
Subject: Re: 2.6.28 headers break kbd and net-tools userspace builds
Date: Mon, 02 Feb 2009 10:35:25 +0000	[thread overview]
Message-ID: <4986CC6D.4090904@walrond.org> (raw)
In-Reply-To: <alpine.LSU.2.00.0901300510310.22910@fbirervta.pbzchgretzou.qr>

Hey guys. A gentle nudge...

My distro scripts build the

    glibc
    iproute2
    iputils
    kbd
    lm_sensors
    net-tools
    strace

packages and others against every new release of linux and linux-stable, 
(hence my initial report).
Right now I'm stalled at the 2.6.27.? headers so can't do any more 
testing until this is resolved.

Andrew Walrond

Jan Engelhardt wrote:
> On Wednesday 2009-01-28 21:29, David Miller wrote:
>   
>>> On Tuesday 2009-01-27 06:08, David Miller wrote:
>>>       
>>>> The fly in the ointment is linux/if_tunnel.h
>>>>
>>>> We export a structure there for a userland interface which
>>>> uses "struct iphdr".
>>>>
>>>> Because of that, we are faced with the difficult choice between
>>>> defining the structure (as we do) in linux/ip.h or using some ugly
>>>> __KERNEL__ ifdefs in linux/if_tunnel.h to conditionally include
>>>> netinet/ip.h instead. :-/
>>>>
>>>> Really, I have no idea what to do about this as the problem has
>>>> existed for so long.
>>>>         
>>> I think in the long term, exported structs should probably
>>> have a "kernel_" prefix, much like userspace libraries use
>>> such prefixes to (try to) guard against simple name clashes.
>>>       
>> This is a reasonable rule for future interfaces, but won't
>> help us here on this one.[...]
>> Really, we page a huge price these days because the relationship
>> between glibc's and the kernel's userland header exports in the
>> past has been anti-social at best.
>>
>>     
> Yeah I just had to notice >:-(
>
> IPPROTO_MH is only defined in linux/in6.h, but inclusion of it:
>
> /usr/include/linux/in6.h:31: error: redefinition of ■struct in6_addr■
> /usr/include/linux/in6.h:52: error: redefinition of ■struct sockaddr_in6■
> /usr/include/linux/in6.h:60: error: redefinition of ■struct ipv6_mreq■
>
> Ick. That's even worse than tunnels.
>
>   


  reply	other threads:[~2009-02-02 10:35 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-01-22 12:45 2.6.28 headers break kbd and net-tools userspace builds Andrew Walrond
2009-01-22 17:56 ` Sam Ravnborg
2009-01-22 19:04   ` Andrew Walrond
     [not found]   ` <4978C301.1040705@walrond.org>
2009-01-22 19:12     ` Sam Ravnborg
2009-01-27  5:08       ` David Miller
2009-01-27 10:44         ` Jan Engelhardt
2009-01-28 20:29           ` David Miller
2009-01-30  4:12             ` Jan Engelhardt
2009-02-02 10:35               ` Andrew Walrond [this message]
2009-02-02 20:05                 ` David Miller
2009-02-02 21:13                   ` Andrew Walrond
2009-02-02 21:24                     ` David Miller
2009-02-02 21:27                       ` David Miller
2009-02-03  4:58                         ` Sam Ravnborg
2009-02-03  5:26                           ` David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4986CC6D.4090904@walrond.org \
    --to=andrew@walrond.org \
    --cc=davem@davemloft.net \
    --cc=jengelh@medozas.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=sam@ravnborg.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.