From: Jeff Garzik <jgarzik@pobox.com>
To: Randy Dunlap <randy.dunlap@oracle.com>
Cc: ide <linux-ide@vger.kernel.org>
Subject: Re: [PATCH -next] libata: fix kernel-doc warnings
Date: Mon, 02 Feb 2009 22:43:02 -0500 [thread overview]
Message-ID: <4987BD46.5000906@pobox.com> (raw)
In-Reply-To: <20090120162859.022628c1.randy.dunlap@oracle.com>
Randy Dunlap wrote:
> From: Randy Dunlap <randy.dunlap@oracle.com>
>
> Fix libata kernel-doc warnings:
>
> Warning(linux-next-20090120//drivers/ata/libata-core.c:4720): Excess function parameter 'dev' description in 'ata_qc_new'
> Warning(linux-next-20090120//drivers/ata/libata-scsi.c:428): No description found for parameter 'ap'
>
> Signed-off-by: Randy Dunlap <randy.dunlap@oracle.com>
> ---
> drivers/ata/libata-core.c | 3 +--
> drivers/ata/libata-scsi.c | 1 +
> 2 files changed, 2 insertions(+), 2 deletions(-)
>
> --- linux-next-20090120.orig/drivers/ata/libata-core.c
> +++ linux-next-20090120/drivers/ata/libata-core.c
> @@ -4709,8 +4709,7 @@ void swap_buf_le16(u16 *buf, unsigned in
>
> /**
> * ata_qc_new - Request an available ATA command, for queueing
> - * @ap: Port associated with device @dev
> - * @dev: Device from whom we request an available command structure
> + * @ap: target port
> *
> * LOCKING:
> * None.
> --- linux-next-20090120.orig/drivers/ata/libata-scsi.c
> +++ linux-next-20090120/drivers/ata/libata-scsi.c
> @@ -414,6 +414,7 @@ int ata_std_bios_param(struct scsi_devic
>
> /**
> * ata_get_identity - Handler for HDIO_GET_IDENTITY ioctl
> + * @ap: target port
> * @sdev: SCSI device to get identify data for
> * @arg: User buffer area for identify data
applied to -rc
prev parent reply other threads:[~2009-02-03 3:43 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-01-21 0:28 [PATCH -next] libata: fix kernel-doc warnings Randy Dunlap
2009-02-03 3:43 ` Jeff Garzik [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4987BD46.5000906@pobox.com \
--to=jgarzik@pobox.com \
--cc=linux-ide@vger.kernel.org \
--cc=randy.dunlap@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.