From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from semihalf.com (semihalf.com [206.130.101.55]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client did not present a certificate) by ozlabs.org (Postfix) with ESMTPS id 8001EDDFA2 for ; Tue, 3 Feb 2009 19:56:20 +1100 (EST) Message-ID: <498806CF.3030004@semihalf.com> Date: Tue, 03 Feb 2009 09:56:47 +0100 From: Grzegorz Bernacki MIME-Version: 1.0 To: Grant Likely Subject: Re: [PATCH v2] Add support for the digsy MTC board. References: <12335905121539-git-send-email-gjb@semihalf.com> In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1 Cc: linuxppc-dev@ozlabs.org List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Grant Likely wrote: > Hey Grzegorz, > > I've pulled your patch into my -next tree, but I made a few changes first: > - I dropped the defconfig changes because they conflict with the > defconfig update that Ben just pulled from me > - I updated the .dts file to reflect changes I was already making to > all the other .dts files > - I added the digsy-mtc board to the Kconfig documentation. > > I've pushed my whole queue of changes out to my -next tree. Please > pull it down and try it out. (Note, this tree will get rebased at > least once before I ask Ben to pull it, so be aware). Make sure that > I haven't broken your .dts file. To get the defconfig change in, you > can either send me another patch with just the defconfig change, or > you can pop my version of your patch off the top of my -next tree and > rebase your entire patch on top it. Whatever you prefer. > > One more note; the new digsy-mtc.dts file from my tree will probably > not work with older kernels. Kernels need to be backward compatible > with older .dts files, but the same is not true for the other way > around. > > Here's my -next tree: > > git://git.secretlab.ca/git/linux-2.6-mpc52xx next > Hi Grant, Thanks for pulling and updating my patch. I got your tree and now I try to build kernel image for digsy, but I get following errors: arch/powerpc/platforms/52xx/mpc52xx_gpt.c:77: error: field 'of_gc' has incomplete type arch/powerpc/platforms/52xx/mpc52xx_gpt.c: In function 'mpc52xx_gpt_gpio_setup':arch/powerpc/platforms/52xx/mpc52xx_gpt.c:350: error: parameter name omitted arch/powerpc/platforms/52xx/mpc52xx_gpt.c:350: error: parameter name omitted They disappear when I add support for OF gpio, but I think that parts of mpc52xx_gpt.c file should be inside '#ifdef CONFIG_OF_GPIO' clause. regards, Grzesiek