All of lore.kernel.org
 help / color / mirror / Atom feed
From: Anthony Liguori <anthony@codemonkey.ws>
To: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] QEMU SVN on Windows 2000 :-(
Date: Tue, 03 Feb 2009 06:31:16 -0600	[thread overview]
Message-ID: <49883914.2030904@codemonkey.ws> (raw)
In-Reply-To: <4987F7F1.2040104@redhat.com>

Avi Kivity wrote:
> Anthony Liguori wrote:
>> Robert Riebisch wrote:
>>> Hi!
>>>
>>> Unfortunately Win32 binaries built from QEMU SVN don't run on Windows
>>> 2000 anymore, because of missing DLL entry points in `ws2_32.dll'.
>>>   
>>
>> Unfortunately, win2k is so old at this point, that I don't know that 
>> it's worth jumping through hoops to support.
>>
>> If someone can come up with a simple patch (with appropriately 
>> licensed code), then I'd be happy to apply it.  Otherwise, I don't 
>> think not supporting win2k as a host is a huge loss.
>>
>
> There is in fact a signed-off two-liner still in the thread:

"but it requires copyrighted file `Wspiapi.h' from MSVC2005, because 
MinGW doesn't provide such a file."

So if Wspiapi.h carries a GPL compatible license, it's fine to include.  
The patch lacks Wspiapi.h though so it'll break the build on mingw.

Regards,

Anthony Liguori

>>>
>>> --- qemu-sockets.c.orig    Wed Jan 14 19:34:22 2009
>>> +++ qemu-sockets.c    Mon Feb 02 22:04:42 2009
>>> @@ -22,6 +22,9 @@
>>>  #include "qemu_socket.h"
>>>  #include "qemu-common.h" /* for qemu_isdigit */
>>>
>>> +#define _inline __inline /* circumvent header file issue */
>>> +#include <wspiapi.h>
>>> +
>>>  #ifndef AI_ADDRCONFIG
>>>  # define AI_ADDRCONFIG 0
>>>  #endif
>>> ***
>>>
>>> Signed-off-by: Robert Riebisch <rr@bttr-software.de>
>
>

  reply	other threads:[~2009-02-03 12:31 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-02-02 21:53 [Qemu-devel] QEMU SVN on Windows 2000 :-( Robert Riebisch
2009-02-02 22:29 ` Anthony Liguori
2009-02-03  7:53   ` Avi Kivity
2009-02-03 12:31     ` Anthony Liguori [this message]
2009-02-03 13:28       ` Daniel P. Berrange
2009-02-03 14:59         ` Anthony Liguori
2009-02-03 16:36           ` David Turner
2009-02-03 21:27             ` Robert Riebisch
2009-02-12 13:57               ` David Turner
2009-02-04 12:28         ` Jamie Lokier
2009-02-04 15:21           ` Robert Reif
2009-02-04 15:40             ` David Coppa
2009-02-04 15:58               ` Paul Brook
2009-02-04 20:11             ` Jamie Lokier
2009-02-04 21:00             ` Luca Tettamanti
2009-02-03 13:59       ` Avi Kivity

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=49883914.2030904@codemonkey.ws \
    --to=anthony@codemonkey.ws \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.