From mboxrd@z Thu Jan 1 00:00:00 1970 From: Derek Ou Date: Tue, 03 Feb 2009 11:44:06 -0700 Subject: [U-Boot] lcd_putc bug? Message-ID: <49889076.5010509@siconix.com> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de In the lcd_putc() of common/lcd.c, line 189 handles tab '\t'. And the following lines: console_col |= 8; console_col &= ~7; seems to have problems. If console_col is 9, it will become 8 after the above two lines, which means instead of tab of 8 spaces, it goes back 1. Is this intentional or a bug? I think it should be console_col += 8; instead of console_col |= 8; Derek