From: Anthony Liguori <aliguori@us.ibm.com>
To: Glauber Costa <glommer@gmail.com>
Cc: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH] don't expose lm bit if kernel is not 64-bit capable.
Date: Tue, 03 Feb 2009 15:14:03 -0600 [thread overview]
Message-ID: <4988B39B.5050509@us.ibm.com> (raw)
In-Reply-To: <5d6222a80902031200i5b46b536vd2a95089d48a098e@mail.gmail.com>
Glauber Costa wrote:
>> It would be better to use KVM_GET_SUPPORTED_CPUID for this (and similar).
>> uname() can lie, and in theory kvm can support x86_64 on i386 kernels
>> (although patches to implement this would be rejected on cost/benefit and
>> aesthetic concerns).
>>
>
> I sent a patch that implements this last week, but anthony seemed to
> be more inclined
> towards this approach.
>
All I said was that if we used KVM_GET_SUPPORTED_CPUID, we had to do
something about save/restore since it can mask arbitrary things.
Regards,
Anthony Liguori
next prev parent reply other threads:[~2009-02-03 21:14 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-02-03 15:04 [Qemu-devel] [PATCH] don't expose lm bit if kernel is not 64-bit capable Glauber Costa
2009-02-03 15:44 ` Alexander Graf
2009-02-03 15:52 ` Glauber Costa
2009-02-03 17:58 ` Anthony Liguori
2009-02-03 19:35 ` Avi Kivity
2009-02-03 19:37 ` Avi Kivity
2009-02-03 20:00 ` Glauber Costa
2009-02-03 21:14 ` Anthony Liguori [this message]
2009-02-03 21:35 ` Glauber Costa
2009-02-03 21:42 ` Anthony Liguori
2009-02-04 8:10 ` Avi Kivity
2009-02-03 19:37 ` Avi Kivity
-- strict thread matches above, loose matches on Subject: below --
2009-02-03 20:15 Glauber Costa
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4988B39B.5050509@us.ibm.com \
--to=aliguori@us.ibm.com \
--cc=glommer@gmail.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.