All of lore.kernel.org
 help / color / mirror / Atom feed
From: phcoder <phcoder@gmail.com>
To: The development of GRUB 2 <grub-devel@gnu.org>
Subject: [Bugfix] Hang on new mac laptops
Date: Tue, 03 Feb 2009 22:30:00 +0100	[thread overview]
Message-ID: <4988B758.5060408@gmail.com> (raw)

Hello. On new mac laptops waiting for keyboard event causes random 
hangs. Bugfix attached
Thanks
Vladimir 'phcoder' Serbinenko

Index: ChangeLog
===================================================================
--- ChangeLog	(revision 1967)
+++ ChangeLog	(working copy)
@@ -1,3 +1,10 @@
+2009-02-03  Vladimir Serbinenko <phcoder@gmail.com>
+
+	Don't rely on event for keyboard on EFI. It causes random hangs
+	Great thanks to Florian Idelberger for testing and helping finding 
this bug
+
+	* term/efi/console.c: Replace wait for event with grub_millisleep (10)
+	
  2009-02-01  Felix Zielcke  <fzielcke@z-51.de>

  	* INSTALL: Note that we now require at least autconf 2.59 and that LZO
Index: term/efi/console.c
===================================================================
--- term/efi/console.c	(revision 1967)
+++ term/efi/console.c	(working copy)
@@ -226,9 +226,10 @@

    do
      {
-      status = efi_call_3 (b->wait_for_event, 1, &(i->wait_for_key), 
&index);
+      /*      status = efi_call_3 (b->wait_for_event, 1, 
&(i->wait_for_key), &index);
        if (status != GRUB_EFI_SUCCESS)
-        return -1;
+        return -1;*/
+      grub_millisleep (10);

        grub_console_checkkey ();
      }



             reply	other threads:[~2009-02-03 21:30 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-02-03 21:30 phcoder [this message]
2009-02-03 22:06 ` [Bugfix] Hang on new mac laptops Pavel Roskin
2009-02-04  7:56   ` phcoder
2009-02-07 22:34     ` Robert Millan
2009-02-08 17:02       ` step21
2009-02-08 18:00         ` Robert Millan
2009-02-08 18:52           ` step21
2009-02-08 19:55             ` Robert Millan
2009-02-09  1:46               ` step21
2009-02-09 14:05                 ` Robert Millan
2009-03-11 20:57     ` phcoder

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4988B758.5060408@gmail.com \
    --to=phcoder@gmail.com \
    --cc=grub-devel@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.