From mboxrd@z Thu Jan 1 00:00:00 1970 From: Yosuke Iwamatsu Subject: [PATCH] xend: Sleep before sending SIGKILL to device model Date: Wed, 04 Feb 2009 15:14:10 +0900 Message-ID: <49893232.8000600@ab.jp.nec.com> References: <49801B68.5060700@ab.jp.nec.com> <18816.15891.759792.425858@mariner.uk.xensource.com> <49816B91.4080809@ab.jp.nec.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <49816B91.4080809@ab.jp.nec.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xensource.com Errors-To: xen-devel-bounces@lists.xensource.com To: Keir Fraser Cc: xen-devel@lists.xensource.com List-Id: xen-devel@lists.xenproject.org Keir, Would you mind applying this? -- Yosuke Yosuke Iwamatsu wrote: > Ian Jackson wrote: >> The code already has a timeout to forcibly kill the device model after >> (I think) 10 seconds. Surely we should reuse that code path (and the >> same timeout value) ? >> >> Restarting xend is not a usual thing to do and I think it's OK if >> shutting down a domain started by a previous xend involves waiting for >> such a longer timeout. It's better to err on the side of safety. > > O.K. Attached is a revised patch which reuses the existing code path. > 10 seconds seems to me a bit too long, but I can agree we had better > keep on the safe side. > >> Also, your patch was: >> Content-Type: all/allfiles; >> This is not a recognised content type and prevented both of my >> mailreaders from displaying it to me. Can you please fix your MUA ? > > Sorry for the inconvenience. > This time your mail client can recognize it, I think. > > -- Yosuke > > Signed-off-by: Yosuke Iwamatsu > > > > > ------------------------------------------------------------------------ > > _______________________________________________ > Xen-devel mailing list > Xen-devel@lists.xensource.com > http://lists.xensource.com/xen-devel