From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with archive (Exim 4.43) id 1LUcck-0004WN-8G for mharc-grub-devel@gnu.org; Wed, 04 Feb 2009 02:56:42 -0500 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1LUccg-0004VH-Mh for grub-devel@gnu.org; Wed, 04 Feb 2009 02:56:38 -0500 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1LUccc-0004Tf-7x for grub-devel@gnu.org; Wed, 04 Feb 2009 02:56:38 -0500 Received: from [199.232.76.173] (port=38771 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1LUccb-0004TZ-UN for grub-devel@gnu.org; Wed, 04 Feb 2009 02:56:33 -0500 Received: from fg-out-1718.google.com ([72.14.220.153]:32224) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1LUccb-0002Ch-4h for grub-devel@gnu.org; Wed, 04 Feb 2009 02:56:33 -0500 Received: by fg-out-1718.google.com with SMTP id l27so1266045fgb.30 for ; Tue, 03 Feb 2009 23:56:31 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:message-id:date:from :user-agent:mime-version:to:subject:references:in-reply-to :content-type; bh=wODY7nXFtlve/Ln9A5lvXbNwQDxU29EQ/9mngRNkkPU=; b=m2EqJ99fJiwnAzxyDFi2S7iQZSFEf0nEGLsFUL//aJPKFmGFPQ3JQgA1vKrpqA38qs Biafj4D1Txxz1pshORLu2zHW3tnURDgJ7Kgg3oEpxjnoTadycUzGvDeK/N+D2Svin1rX SVxAXY9zp/Rt46fSPYkroqwJjZuXfWXn+qvzg= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=message-id:date:from:user-agent:mime-version:to:subject:references :in-reply-to:content-type; b=dYJo5Q5XFtO7FaNPDWe3gYhVgwEbHw0CS4jcYJr+B4oPeHx5mIlEXh9MSxXIH/q+zI 3IwzToRFC2KwN37zRGOhLhelDtb5VnTiFigdthiZ1IIU+95XghUpBlHTdS5wK+PvlfMN 17/fZeiyOiVnTVke6nNfKp3i20TUslV59iaJQ= Received: by 10.86.95.20 with SMTP id s20mr932003fgb.40.1233734191753; Tue, 03 Feb 2009 23:56:31 -0800 (PST) Received: from ?192.168.1.25? (119-114.62-81.cust.bluewin.ch [81.62.114.119]) by mx.google.com with ESMTPS id d6sm1417286fga.39.2009.02.03.23.56.30 (version=SSLv3 cipher=RC4-MD5); Tue, 03 Feb 2009 23:56:30 -0800 (PST) Message-ID: <49894A2C.7040509@gmail.com> Date: Wed, 04 Feb 2009 08:56:28 +0100 From: phcoder User-Agent: Thunderbird 2.0.0.19 (X11/20090105) MIME-Version: 1.0 To: The development of GRUB 2 References: <4988B758.5060408@gmail.com> <1233698760.17258.5.camel@dv> In-Reply-To: <1233698760.17258.5.camel@dv> Content-Type: multipart/mixed; boundary="------------010708080701020301020905" X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6 (newer, 2) Subject: Re: [Bugfix] Hang on new mac laptops X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: The development of GRUB 2 List-Id: The development of GRUB 2 List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 04 Feb 2009 07:56:39 -0000 This is a multi-part message in MIME format. --------------010708080701020301020905 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Fixed Pavel Roskin wrote: > On Tue, 2009-02-03 at 22:30 +0100, phcoder wrote: >> - status = efi_call_3 (b->wait_for_event, 1, &(i->wait_for_key), >> &index); >> + /* status = efi_call_3 (b->wait_for_event, 1, >> &(i->wait_for_key), &index); >> if (status != GRUB_EFI_SUCCESS) >> - return -1; >> + return -1;*/ >> + grub_millisleep (10); > > Please don't leave commented out code. If you want a comment to be > there, you can write something. If you want to preserve the file > history, Subversion does it already. > --------------010708080701020301020905 Content-Type: text/x-diff; name="efikey.diff" Content-Transfer-Encoding: 7bit Content-Disposition: inline; filename="efikey.diff" Index: ChangeLog =================================================================== --- ChangeLog (revision 1967) +++ ChangeLog (working copy) @@ -1,3 +1,10 @@ +2009-02-04 Vladimir Serbinenko + + Don't rely on event for keyboard on EFI. It causes random hangs + Great thanks to Florian Idelberger for testing and helping finding this bug + + * term/efi/console.c: Replace wait for event with grub_millisleep (10) + 2009-02-01 Felix Zielcke * INSTALL: Note that we now require at least autconf 2.59 and that LZO Index: term/efi/console.c =================================================================== --- term/efi/console.c (revision 1967) +++ term/efi/console.c (working copy) @@ -226,9 +226,9 @@ do { - status = efi_call_3 (b->wait_for_event, 1, &(i->wait_for_key), &index); - if (status != GRUB_EFI_SUCCESS) - return -1; + /* Don't use wait_for_event it's known + to cause hangs on some mac models */ + grub_millisleep (10); grub_console_checkkey (); } --------------010708080701020301020905--