From: Li Zefan <lizf@cn.fujitsu.com>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: Paul Menage <menage@google.com>,
LKML <linux-kernel@vger.kernel.org>,
Linux Containers <containers@lists.linux-foundation.org>
Subject: Re: [PATCH] cgroups: fix lockdep subclasses overflow
Date: Wed, 04 Feb 2009 17:15:25 +0800 [thread overview]
Message-ID: <49895CAD.1020008@cn.fujitsu.com> (raw)
In-Reply-To: <49895BD7.8090405@cn.fujitsu.com>
Li Zefan wrote:
> I enabled all cgroup subsystems when compiling kernel, and then:
> # mount -t cgroup -o net_cls xxx /mnt
> # mkdir /mnt/0
>
> This showed up immediately:
> BUG: MAX_LOCKDEP_SUBCLASSES too low!
> turning off the locking correctness validator.
>
> It's caused by the cgroup hierarchy lock:
> for (i = 0; i < CGROUP_SUBSYS_COUNT; i++) {
> struct cgroup_subsys *ss = subsys[i];
> if (ss->root == root)
> mutex_lock_nested(&ss->hierarchy_mutex, i);
> }
>
> Now we have 9 cgroup subsystems, and the above 'i' for net_cls is 9, but
sorry, a typo here: the above 'i' for net_cls is 8.
> MAX_LOCKDEP_SUBCLASSES is 8.
>
> This patch uses different lockdep keys for different subsystems.
>
> Signed-off-by: Li Zefan <lizf@cn.fujitsu.com>
> ---
next prev parent reply other threads:[~2009-02-04 9:16 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-02-04 9:11 [PATCH] cgroups: fix lockdep subclasses overflow Li Zefan
[not found] ` <49895BD7.8090405-BthXqXjhjHXQFUHtdCDX3A@public.gmane.org>
2009-02-04 9:15 ` Li Zefan
2009-02-04 15:48 ` Paul Menage
2009-02-04 9:15 ` Li Zefan [this message]
2009-02-04 15:48 ` Paul Menage
-- strict thread matches above, loose matches on Subject: below --
2009-02-04 9:11 Li Zefan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=49895CAD.1020008@cn.fujitsu.com \
--to=lizf@cn.fujitsu.com \
--cc=akpm@linux-foundation.org \
--cc=containers@lists.linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=menage@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.