From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stefano Stabellini Subject: Re: Re: 2 errors with latest Xen Date: Wed, 04 Feb 2009 12:10:04 +0000 Message-ID: <4989859C.1020505@eu.citrix.com> References: Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xensource.com Errors-To: xen-devel-bounces@lists.xensource.com To: Jun Koi Cc: "xen-devel@lists.xensource.com" List-Id: xen-devel@lists.xenproject.org Jun Koi wrote: > On Wed, Feb 4, 2009 at 12:35 PM, Jun Koi wrote: >> Hi, >> >> I use the latest Xen from hg repo to run 2 HVM here. I got the >> problem: all these 2 cannot be started. >> >> 1) For a Vista VM: qemu-dm.log says that "/usr/lib/xen/bin/qemu-dm: >> invalid option -- '-vncviewer' " >> I can confirm that I have no vncviewer option in my configuration. So >> this is very confused. > > It seems that for some unknown reasons, xen run qemu-dm with option > -vncviewer, and qemu-dm complains about that (then it failed to > start). > > I notice that I dont have this problem with Linux HVM, but only with > Vista HVM. Is there any reason why xen behaves differently on Vista > and Linux HVM? (there is no difference between configurations) > The vncconsole option seems to be broken. The following patch fixes the problem for me. diff -r c3b5e36248c9 tools/python/xen/xend/image.py --- a/tools/python/xen/xend/image.py Tue Feb 03 18:14:19 2009 +0000 +++ b/tools/python/xen/xend/image.py Wed Feb 04 12:04:07 2009 +0000 @@ -372,8 +372,6 @@ env['DISPLAY'] = self.display if self.xauthority: env['XAUTHORITY'] = self.xauthority - if self.vncconsole: - args = args + ([ "-vncviewer" ]) unique_id = "%i-%i" % (self.vm.getDomid(), time.time()) sentinel_path = sentinel_path_prefix + unique_id sentinel_path_fifo = sentinel_path + '.fifo' diff -r c3b5e36248c9 tools/python/xen/xm/create.py --- a/tools/python/xen/xm/create.py Tue Feb 03 18:14:19 2009 +0000 +++ b/tools/python/xen/xm/create.py Wed Feb 04 12:04:07 2009 +0000 @@ -1337,7 +1337,7 @@ elif not opts.is_xml: dom = make_domain(opts, config) - if opts.vals.vncviewer: + if opts.vals.vncconsole: domid = domain_name_to_domid(sxp.child_value(config, 'name', -1)) vncviewer_autopass = getattr(opts.vals,'vncviewer-autopass', False) console.runVncViewer(domid, vncviewer_autopass, True)