From: Ben Warren <biggerbadderben@gmail.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v3] Add support for the digsy MTC board.
Date: Wed, 04 Feb 2009 09:57:15 -0800 [thread overview]
Message-ID: <4989D6FB.10303@gmail.com> (raw)
In-Reply-To: <12337530013673-git-send-email-gjb@semihalf.com>
Hi Grzegorz,
Grzegorz Bernacki wrote:
> This is the InterControl custom device based on the MPC5200B chip.
>
> Signed-off-by: Grzegorz Bernacki <gjb@semihalf.com>
> ---
> Version 3:
> - updated (c)
> Version 2:
> - use I/O accessor functions instead of volatile pointer
> - set ethernet address only if not set in environment
> - add some comments and some style cleanup
>
>
<snip>
> diff --git a/drivers/net/mpc5xxx_fec.c b/drivers/net/mpc5xxx_fec.c
> index f8618b1..a1c72d6 100644
> --- a/drivers/net/mpc5xxx_fec.c
> +++ b/drivers/net/mpc5xxx_fec.c
> @@ -893,6 +893,7 @@ int mpc5xxx_fec_initialize(bd_t * bis)
> fec->rbdBase = (FEC_RBD *)(FEC_BD_BASE + FEC_TBD_NUM * sizeof(FEC_TBD));
> #if defined(CONFIG_CANMB) || \
> defined(CONFIG_CM5200) || \
> + defined(CONFIG_DIGSY_MTC) || \
> defined(CONFIG_HMI1001) || \
> defined(CONFIG_ICECUBE) || \
> defined(CONFIG_INKA4X0) || \
>
No more adding to this mess, please. This absolutely belongs in board
code. I know you're not responsible for it, so if you don't have time
to clean it up I can do so and supply an untested patch.
<snip>
regards,
Ben
next prev parent reply other threads:[~2009-02-04 17:57 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-02-04 13:10 [U-Boot] [PATCH v3] Add support for the digsy MTC board Grzegorz Bernacki
2009-02-04 17:57 ` Ben Warren [this message]
2009-02-05 8:30 ` Grzegorz Bernacki
2009-02-06 8:00 ` Ben Warren
2009-02-09 8:48 ` Grzegorz Bernacki
2009-02-09 18:00 ` Ben Warren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4989D6FB.10303@gmail.com \
--to=biggerbadderben@gmail.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.